Added PSetTemplate to allow description of a PSet

[Dr15Jones]

PR description:

This is used in conjunction with required or optional functionality to describe the allowed parameters of a PSet.

PR validation:

The python unit tests pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31841/19173

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/ParameterSet

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10055/console Started: 2020/10/18 18:19

[cmsbuild]

-1

Tested at: 5a12a5b

CMSSW: CMSSW_11_2_X_2020-10-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• use standard libuuid functions, add binary uuid option #31658 @dan131riley: use standard libuuid functions, add binary uuid option
• Migrate some Muon helper classes and EDProducers to EventSetup consumes #31834 @makortel: Migrate some Muon helper classes and EDProducers to EventSetup consumes
• Remove obsolete records #31780 @christopheralanwest: Remove obsolete records
• Complete EventSetup-consumes migration for HBHEIsolatedNoiseReflagger #31835 @makortel: Complete EventSetup-consumes migration for HBHEIsolatedNoiseReflagger
• Require highPurity for isolated tracks in heavy-ion workflows #31727 @mandrenguyen: Require highPurity for isolated tracks in heavy-ion workflows

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10055/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10055/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10055/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreParameterSetDriver had ERRORS
---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• use standard libuuid functions, add binary uuid option #31658 @dan131riley: use standard libuuid functions, add binary uuid option
• Migrate some Muon helper classes and EDProducers to EventSetup consumes #31834 @makortel: Migrate some Muon helper classes and EDProducers to EventSetup consumes
• Remove obsolete records #31780 @christopheralanwest: Remove obsolete records
• Complete EventSetup-consumes migration for HBHEIsolatedNoiseReflagger #31835 @makortel: Complete EventSetup-consumes migration for HBHEIsolatedNoiseReflagger
• Require highPurity for isolated tracks in heavy-ion workflows #31727 @mandrenguyen: Require highPurity for isolated tracks in heavy-ion workflows

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10055/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10055/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31841/19176

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/ParameterSet/python/Config.py modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10060/console Started: 2020/10/18 21:21

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10055/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543729
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cmsbuild]

-1

Tested at: bc71867

CMSSW: CMSSW_11_2_X_2020-10-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• use standard libuuid functions, add binary uuid option #31658 @dan131riley: use standard libuuid functions, add binary uuid option
• Migrate some Muon helper classes and EDProducers to EventSetup consumes #31834 @makortel: Migrate some Muon helper classes and EDProducers to EventSetup consumes
• Remove obsolete records #31780 @christopheralanwest: Remove obsolete records
• Complete EventSetup-consumes migration for HBHEIsolatedNoiseReflagger #31835 @makortel: Complete EventSetup-consumes migration for HBHEIsolatedNoiseReflagger
• Require highPurity for isolated tracks in heavy-ion workflows #31727 @mandrenguyen: Require highPurity for isolated tracks in heavy-ion workflows

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10060/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10060/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10060/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• use standard libuuid functions, add binary uuid option #31658 @dan131riley: use standard libuuid functions, add binary uuid option
• Migrate some Muon helper classes and EDProducers to EventSetup consumes #31834 @makortel: Migrate some Muon helper classes and EDProducers to EventSetup consumes
• Remove obsolete records #31780 @christopheralanwest: Remove obsolete records
• Complete EventSetup-consumes migration for HBHEIsolatedNoiseReflagger #31835 @makortel: Complete EventSetup-consumes migration for HBHEIsolatedNoiseReflagger
• Require highPurity for isolated tracks in heavy-ion workflows #31727 @mandrenguyen: Require highPurity for isolated tracks in heavy-ion workflows

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10060/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10060/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07dad/10060/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543726
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[Dr15Jones]

The unit test failure is from the IB, not this pull request

[christopheralanwest]

The failure will be resolved with the merging of #31729, which was intended to be merged at the same time as #31780.

[makortel]

+1

Could you update the documentation https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideAboutPythonConfigFile#Parameters_without_defaults with the allowAnyLabel_ and PSetTemplate?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

@makortel documentation has been updated.

[silviodonato]

+1

[silviodonato]

merge