New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Reintroduce Namespace #31886
[DD4hep] Reintroduce Namespace #31886
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31886/19287
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
-1 Tested at: b5e425c CMSSW: CMSSW_11_2_X_2020-10-20-2300 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testDD4hepFilteredViewGoTo had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@ianna , could this PR be the reason behind failing unit tests in IBs? Tests are failing due to differences in the logs |
ok #31934 might fix the issue |
PR description:
Note: now there are two member functions in
DDNamespace
that do pretty much the same thing:addVolumeNS
andaddVolume
. A general cleanup will be done to keep the latter after this PR is merged.PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: