Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed TrackPropagation/Geant4e from Threaded branch #3190

Merged
merged 1 commit into from Apr 9, 2014
Merged

Removed TrackPropagation/Geant4e from Threaded branch #3190

merged 1 commit into from Apr 9, 2014

Conversation

Dr15Jones
Copy link
Contributor

The Geant4e based propagator is not presently thread safe. To avoid
problems with the static analyzer we are removing it from the threaded
branch. If the code is made thread safe, we will add it back.

@Dr15Jones
Removed TrackPropagation/Geant4e from Threaded branch
f3fcdb6 
The Geant4e based propagator is not presently thread safe. To avoid
problems with the static analyzer we are removing it from the threaded
branch. If the code is made thread safe, we will add it back.
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_THREADED_X.

Removed TrackPropagation/Geant4e from Threaded branch

It involves the following packages:

TrackPropagation/Geant4e

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

@davidlange6 This was the solution David Lange approved for handling this case.

@Dr15Jones
Copy link
Contributor Author

@nclopezo ping?

@ktf
Copy link
Contributor

ktf commented Apr 7, 2014

I started the tests, should be done in a bit.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2014

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 08-Apr-2014 00:21:28 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
----- Begin Fatal Exception 08-Apr-2014 00:21:28 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 08-Apr-2014 00:21:40 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log
----- Begin Fatal Exception 08-Apr-2014 00:22:00 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 08-Apr-2014 00:22:02 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 08-Apr-2014 00:22:04 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 08-Apr-2014 00:22:19 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log
----- Begin Fatal Exception 08-Apr-2014 00:22:23 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 08-Apr-2014 00:22:56 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 08-Apr-2014 00:23:38 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 08-Apr-2014 00:28:45 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 08-Apr-2014 00:29:59 CEST-----------------------
An exception of category 'ConnectedToObsoleteServiceSignal' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type DTDataIntegrityTask
Exception Message:
A Service has connected to an obsolete ActivityRegistry signal.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3190/801/summary.html

@Dr15Jones
Copy link
Contributor Author

Jobs must be run using the special customize function

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

-1
When I ran the RelVals I found an error in the following worklfows:
25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3190/848/summary.html

@Dr15Jones
Copy link
Contributor Author

@nclopezo @ktf this is the same workflow which is known to have existing threading problems. Please go ahead and merge this pull request since the code in this pull is never used in any CMS jobs.

ktf added a commit that referenced this pull request Apr 9, 2014
@ktf
Merge pull request #3190 from Dr15Jones/removeTrackPropagationGeant4e…
72217c6 
…FromThreaded

Multithreading -- Removed TrackPropagation/Geant4e from Threaded branch
@ktf ktf merged commit 72217c6 into cms-sw:CMSSW_7_1_THREADED_X Apr 9, 2014
@Dr15Jones Dr15Jones deleted the removeTrackPropagationGeant4eFromThreaded branch April 14, 2014 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending pending-signatures simulation-pending tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @ktf