GEM unpacker: crash protection from bad FEDs

[jshlee]

PR description:

GEM unpacker (GEMRawToDigiModule) was crashing run 337971 MWGR.
This was due to wrong DAQ setting producing invalid GEM chamber and vfat IDs.
It was fixed with #31863 and this is backporting the same fix.
Not full backport due to many commits in 11_2_X.

PR validation:

• tested with wf 11611.0, 23211.0 and run 337971 MWGR data.

[cmsbuild]

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_11_1_X.

It involves the following packages:

EventFilter/GEMRawToDigi

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @watson-ij this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-10-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10258/console Started: 2020/10/23 20:18

[cmsbuild]

+1
Tested at: a7c4f7a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40ba2c/10258/summary.html
CMSSW: CMSSW_11_1_X_2020-10-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40ba2c/10258/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2784776
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2784725
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

+1

for #31928 a7c4f7a

• code changes are in line with the PR description: a part related to bad data checks is backported from GEM unpacker: bugfix and more cross checks #31863
• jenkins tests pass and comparisons with the baseline show no (relevant) differences
• a local test with a cosmic data from 337971 shows that a crash goes away with an expected warning message

%MSG-w GEMRawToDigiModule:  GEMRawToDigiModule:muonGEMDigis  24-Oct-2020 02:11:56 CEST Run: 337971 Event: 23852
unpacking error: unknown Chamber 1 unknown VFat 0 bad VFat 0

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1