Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] No Namespace in MuonG4Numbering nor in Tracker SD #31949

Merged
merged 2 commits into from Oct 28, 2020

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Oct 27, 2020

PR description:

  • While a proper solution is going to be provided by @ghugo83 this patch will allow to run step1 to completion

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31949/19403

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4CMS/Tracker

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Oct 27, 2020

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ianna ianna changed the title [DD4hep] No Namespace in Tracker SD - stop gap solution [DD4hep] No Namespace in MuonG4Numbering nor in Tracker SD - stop gap solution Oct 27, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31949/19404

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #31949 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Oct 27, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 401af50
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-425052/10314/summary.html
CMSSW: CMSSW_11_2_X_2020-10-26-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-425052/10314/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@ianna
Copy link
Contributor Author

ianna commented Oct 28, 2020

@civanch and @cvuosalo - this allows step1 run to completion without any errors

@ianna ianna changed the title [DD4hep] No Namespace in MuonG4Numbering nor in Tracker SD - stop gap solution [DD4hep] No Namespace in MuonG4Numbering nor in Tracker SD Oct 28, 2020
@ianna
Copy link
Contributor Author

ianna commented Oct 28, 2020

urgent

@ianna
Copy link
Contributor Author

ianna commented Oct 28, 2020

@civanch - please, consider reviewing this PR for 11 am IB

@civanch
Copy link
Contributor

civanch commented Oct 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 28, 2020

+1

@cmsbuild cmsbuild merged commit 8a60385 into cms-sw:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants