Mini-PR: Fix EcalBaseNumber::getCopyNumber behavior

[ghugo83]

As mentioned in #31882 and emails, can just remove the namespace in addLevel in ECalSD instead of changing EcalBaseNumber::getCopyNumber behavior.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31963/19419

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @ghugo83 for master.

It involves the following packages:

Geometry/EcalCommonData
SimG4CMS/Calo

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @rovere, @argiro, @makortel, @thomreis, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10339/console Started: 2020/10/28 13:01

[ianna]

@smuzaffar - is it possible to request a custom runTehMatrix test for this PR? Thanks!

[smuzaffar]

what do you mean by custom runTheMatrix test?

[ianna]

please test workflow runTheMatrix.py -l 11607.911 --what upgrade

[smuzaffar]

if you want to run an extra workflow then just request the tests by commenting please test workflow wf1,wf2
this will run normal workflows plus wf1,wf2

[smuzaffar]

--what upgrade is not possible but trying with please test workflow 11607.911

[ianna]

please test workflow 11607.911

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 11607.911
• CMSSW_11_2_X_2020-10-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10341/console Started: 2020/10/28 13:18

[smuzaffar]

@ianna , so right now this combination does not work. when you use --what upgrade then other standard workflows are not loaded. I think this is limitation of runTheMatrix . For now we are to test this PR without --what upgrade option

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• CMSSW_11_2_X_2020-10-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10358/console Started: 2020/10/28 16:18

[cmsbuild]

+1
Tested at: 08b8ac3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-822af5/10358/summary.html
CMSSW: CMSSW_11_2_X_2020-10-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-822af5/10358/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544092
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544063
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cvuosalo]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[fabiocos]

@ianna @smuzaffar in case an upgrade test is needed, at present one needs to add it to the standard matrix, see https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_2026.py

@ianna as far as I can see this PR mimics what done time ago for MTD (I took the baseNumber approach from ECAL)