[DD4hep] Preshower Algo cleanup #31989

ianna · 2020-10-29T17:47:38Z

PR description:

Reduce overlaps from ~50 cm to a few ~ 5 cm
Anticipating a fix in DD4hep for material verbosity

@bsunanda - FYI, not all but most of the overlaps are gone

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-10-29T17:48:00Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-29T17:56:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31989/19473

This PR adds an extra 20KB to repository

cmsbuild · 2020-10-29T17:56:38Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/EcalCommonData
SimG4Core/Geometry

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @rovere, @argiro, @rchatter, @thomreis, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

ianna · 2020-10-29T21:35:05Z

please test

cmsbuild · 2020-10-29T21:35:30Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-29-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10397/console Started: 2020/10/29 22:36

cmsbuild · 2020-10-29T21:39:43Z

-1

Tested at: 041a31d

CMSSW: CMSSW_11_2_X_2020-10-29-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44ea9a/10397/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2020-10-29T21:39:45Z

Comparison job queued.

civanch · 2020-10-29T22:12:28Z

@smuzaffar , @mrodozov , this ClangBuild problem obviously not connected to this PR?

mrodozov · 2020-10-29T22:34:05Z

@cirkovic it says there are few unused variables if you see the log:

Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:464:27: warning: unused variable 'dd_tmp_name_5d' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:465:27: warning: unused variable 'dd_tmp_name_5e' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:565:27: warning: unused variable 'dd_tmp_name_c' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:566:27: warning: unused variable 'dd_tmp_name_d' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:567:27: warning: unused variable 'dd_tmp_name_e' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:605:29: warning: unused variable 'dd_tmp_name_c' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:606:29: warning: unused variable 'dd_tmp_name_d' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:607:29: warning: unused variable 'dd_tmp_name_e' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:644:29: warning: unused variable 'dd_tmp_name_d' [-Wunused-variable]
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-29-1100/src/Geometry/EcalCommonData/plugins/dd4hep/DDEcalPreshowerAlgo.cc:645:29: warning: unused variable 'dd_tmp_name_e' [-Wunused-variable]

cmsbuild · 2020-10-30T15:32:34Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-30T15:39:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31989/19482

This PR adds an extra 20KB to repository

cmsbuild · 2020-10-30T15:39:29Z

Pull request #31989 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

ianna · 2020-10-30T16:28:39Z

please test

cmsbuild · 2020-10-30T16:29:01Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10410/console Started: 2020/10/30 17:29

cmsbuild · 2020-10-30T17:46:37Z

+1
Tested at: c8e9072
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44ea9a/10410/summary.html
CMSSW: CMSSW_11_2_X_2020-10-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-30T17:46:39Z

Comparison job queued.

cmsbuild · 2020-10-30T19:01:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44ea9a/10410/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544092
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544063
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

civanch · 2020-10-30T21:41:19Z

+1

cmsbuild · 2020-10-30T21:41:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-10-31T01:15:18Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Oct 29, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending labels Oct 29, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2020

cmsbuild added tests-rejected and removed tests-started labels Oct 29, 2020

ianna added 2 commits October 30, 2020 16:14

update preshower algo

6940507

correct clang errors

c8e9072

ianna force-pushed the dd4hep-preshower-v1 branch from 041a31d to c8e9072 Compare October 30, 2020 15:32

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Oct 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 30, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 30, 2020

cmsbuild added fully-signed geometry-approved simulation-approved and removed geometry-pending pending-signatures simulation-pending labels Oct 30, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 31, 2020

cmsbuild merged commit 834f116 into cms-sw:master Oct 31, 2020

cmsbuild mentioned this pull request Nov 4, 2020

Switch to Geant4 thermal neutron physics #32009

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4hep] Preshower Algo cleanup #31989

[DD4hep] Preshower Algo cleanup #31989

ianna commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

ianna commented Oct 29, 2020

cmsbuild commented Oct 29, 2020 •

edited

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

civanch commented Oct 29, 2020

mrodozov commented Oct 29, 2020

cmsbuild commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

ianna commented Oct 30, 2020

cmsbuild commented Oct 30, 2020 •

edited

cmsbuild commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

civanch commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

qliphy commented Oct 31, 2020

[DD4hep] Preshower Algo cleanup #31989

[DD4hep] Preshower Algo cleanup #31989

Conversation

ianna commented Oct 29, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

ianna commented Oct 29, 2020

cmsbuild commented Oct 29, 2020 • edited

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

civanch commented Oct 29, 2020

mrodozov commented Oct 29, 2020

cmsbuild commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

ianna commented Oct 30, 2020

cmsbuild commented Oct 30, 2020 • edited

cmsbuild commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

civanch commented Oct 30, 2020

cmsbuild commented Oct 30, 2020

qliphy commented Oct 31, 2020

cmsbuild commented Oct 29, 2020 •

edited

cmsbuild commented Oct 30, 2020 •

edited