New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SiPixelStatusProducer a stream EDProducer for concurrent lumiblock processing #32012
Make SiPixelStatusProducer a stream EDProducer for concurrent lumiblock processing #32012
Conversation
…xelStatusProducer
…un returns pointer to const SiPixelTopo
…ldetectorstatus to txt for each lumi
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32012/19539
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Comparison is ready Comparison Summary:
|
please test workflow 1001.2, 1040 |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
SiPixelStatusProducer was first written as a One EDProducer to produce SiPixelCalZeroBias ALCARECO in ExpressPhysics stream.
To make it compatible with concurrent lumiblock processing, this PR changes it to be a stream module.
Parameters such as "resetNlumi" are obsolete and removed after moving to stream EDProducer,
as the module will now only put product to each lumi block not combining product for several lumiblock sections.
SiPixelTopoFinder class is design to contain maps that contains the tracker FED, geometry and topology.
GlobalCache is contructed to make sure these maps will only be produced when tracker FED, geometry or topology changes across run.
globalEndLumiBlockSummary is used to summarize partial digi occupancy and FED error information from each instance of the module and globalEndLumiBlockProducer combines particle information and put the product into current Lumiblock.
The rest of the codes are basically the same as they were, just change of the structures.
PR validation:
The product of the EDProducer, digi occupancy, can be dumped into text file for each lumi section.
The text file is the same before and after this PR, and the same when changing the concurrentLlumiBlock from one to two in the SiPixelCalZeroBias production using the config file in CalibTracker/SiPixelQuality/test/step3_SiPixelCalZeroBias_RAW2DIGI_RECO_ALCA.py.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport
Before submitting your pull requests, make sure you followed this checklist: