Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SiPixelStatusProducer a stream EDProducer for concurrent lumiblock processing #32012

Merged
merged 21 commits into from Nov 13, 2020

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Nov 3, 2020

PR description:

SiPixelStatusProducer was first written as a One EDProducer to produce SiPixelCalZeroBias ALCARECO in ExpressPhysics stream.
To make it compatible with concurrent lumiblock processing, this PR changes it to be a stream module.
Parameters such as "resetNlumi" are obsolete and removed after moving to stream EDProducer,
as the module will now only put product to each lumi block not combining product for several lumiblock sections.

SiPixelTopoFinder class is design to contain maps that contains the tracker FED, geometry and topology.
GlobalCache is contructed to make sure these maps will only be produced when tracker FED, geometry or topology changes across run.

globalEndLumiBlockSummary is used to summarize partial digi occupancy and FED error information from each instance of the module and globalEndLumiBlockProducer combines particle information and put the product into current Lumiblock.

The rest of the codes are basically the same as they were, just change of the structures.

PR validation:

The product of the EDProducer, digi occupancy, can be dumped into text file for each lumi section.
The text file is the same before and after this PR, and the same when changing the concurrentLlumiBlock from one to two in the SiPixelCalZeroBias production using the config file in CalibTracker/SiPixelQuality/test/step3_SiPixelCalZeroBias_RAW2DIGI_RECO_ALCA.py.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32012/19539

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c6420/10468/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Nov 4, 2020

please test workflow 1001.2, 1040

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

+1
Tested at: 02e3094
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c6420/10488/summary.html
CMSSW: CMSSW_11_2_X_2020-11-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c6420/10488/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7c6420/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7c6420/1040.0_RunZeroBias2017F+RunZeroBias2017F+TIER0RAWSIPIXELCAL+ALCASPLITSIPIXELCAL+ALCAHARVDSIPIXELCAL

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@yuanchao
Copy link
Contributor

+1
Though the new mutable variables would have Thread Safety concern according to the stat. check

  • Logic error warnings (SiPixelDetectorStatus.cc, SiPixelStatusManager.cc) are not part of the PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 198b3c8 into cms-sw:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants