Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read SLHA from TTree [9_4_X] #32019

Merged
merged 1 commit into from Nov 6, 2020
Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Nov 3, 2020

backport of #31733

This backport was actually successful with cms-rebase-topic (starting from #32018).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_4_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Nov 3, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

+1
Tested at: d38dba0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40f143/10487/summary.html
CMSSW: CMSSW_9_4_X_2020-11-01-0000
SCRAM_ARCH: slc6_amd64_gcc630

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40f143/10487/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 105
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721226
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@silviodonato
Copy link
Contributor

@kpedro88 could you add in the description the reason of the backport? (I guess it is for the production with fast sim)

@agrohsje
Copy link

agrohsje commented Nov 4, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
@kpedro88 I assume we need this backport for fastsim

@cmsbuild cmsbuild merged commit 7b9e6a6 into cms-sw:CMSSW_9_4_X Nov 6, 2020
@kpedro88
Copy link
Contributor Author

kpedro88 commented Nov 6, 2020

@silviodonato yes, this is for pMSSM production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants