Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T CondFormats classes updates for UTM v_0.8.1 (v_0.8.0) #32020

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Nov 4, 2020

PR description:

Needed updates for L1T CondFormat classes for updated external library UMT v_0.8_1 or v_0.8.0.

PR validation:

Needs UTM v_0.8.1 installed (cms-sw/cmsdist#6338)
Validated with locally updated UTM to v_0.8.1 and executing the workflow 136.793, which was previously failing.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32020/19560

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

A new Pull Request was created by @rekovic for master.

It involves the following packages:

CondFormats/L1TObjects

@yuanchao, @christopheralanwest, @tocheng, @jmduarte, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor

mrodozov commented Nov 4, 2020

please test with cms-sw/cmsdist#6338
@rekovic you can do the same for the 11_1 backport of this with cms-sw/cmsdist#6340

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6338

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

+1
Tested at: 8911f52
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42fda4/10520/summary.html
CMSSW: CMSSW_11_2_X_2020-11-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42fda4/10520/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544144
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544121
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Nov 6, 2020

+1

@rekovic
Copy link
Contributor Author

rekovic commented Nov 7, 2020

@christopheralanwest and @ggovi
Can you please comment or sign. We would like this for MWGR. Thanks.

@qliphy
Copy link
Contributor

qliphy commented Nov 9, 2020

urgent
for next MWGR

@cmsbuild cmsbuild added the urgent label Nov 9, 2020
@yuanchao
Copy link
Contributor

yuanchao commented Nov 9, 2020

+1

  • static checks warnings are not part of the modifications
  • with c++11 destructor
  • better naming on variables

@silviodonato
Copy link
Contributor

@ggovi do you have any comments?

@ggovi
Copy link
Contributor

ggovi commented Nov 10, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3436704 into cms-sw:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants