New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mirrored finders in RecoMuon from TrackingTools/DetLayer with the original ones #32029
Replace mirrored finders in RecoMuon from TrackingTools/DetLayer with the original ones #32029
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32029/19576
|
A new Pull Request was created by @perrotta for master. It involves the following packages: RecoMuon/DetLayers @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following the resolution of the MTD related part of issue #24452 by PR #32026 (from @fabiocos), I address here the part of the comment which referred to RecoMuon's instead, so that it is resolved as well.
The issue claimed that there was no reason to maintain all files like (e.g.)
RecoMuon/DetLayers/src/RBorderFinder.h
which just mirror (e.g.)TrackingTools/DetLayers/interface/RBorderFinder.h
.With this PR I'm going to replace their inclusion in
RecoMuon/DetLayers
with the one of the original headers fromTrackingTools/DetLayers
PR validation:
It builds, that's enough
No changes expected