Run2-gex35 Add modified PhaseI pixel barrel geometry xml's for 2017 scenario #32059
Conversation
|
The code-checks are being triggered in jenkins. |
|
@cmsbuild Please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32059/19654
|
|
The tests are being triggered in jenkins.
|
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Hi @bsunanda, what is this about? |
|
@mmmusich There was a request from higgs to gamma gamma group of defining scenarios for 17, 18 with tracker material budget reduced/increased by 5% and 10% for their systematic studies of Higgs mass. I just took it up. Sorry I should have forwarded to Tracker DPG - this came about in the group looking for dd4hep transition team. I am forwarding the mail |
|
@bsunanda Could you please explain what the 2017 scenario is? Is it a standard Run 2 scenario? Or is it a material variation scenario? |
|
@cvuosalo These xml files can be used for default as well as with changed MB with a suitable choice of the materials file. In the existing xml files in PhaseI area which are used for 2017/18 scenario, they need a set of material files which cannot take care of varying MB material files. These files are committed mainly in view of defining +-5%, +-10% variation in the material file. |
|
@cvuosalo The cfi files in Geometry/TrackerCommonData area are used for testing - standard scenarios exist in Geometry/CMSCommonData |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -35,18 +35,18 @@ | |||
| 'Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdbladeInnerZminus.xml', | |||
| 'Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdbladeOuterZplus.xml', | |||
| 'Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdbladeOuterZminus.xml', | |||
| 'Geometry/TrackerCommonData/data/PhaseI/v2/pixbarmaterial.xml', | |||
There was a problem hiding this comment.
Is it allowed to change the existing extended geometries?
There was a problem hiding this comment.
This is not a replacement of the existing scenario. The existing scenarios are in Geometry/CMSCommonData. This is a test scenario to check the xml files where all tracker related materials are removed from materials.xml so that their densities can be reduced or increased to make some systematic studies. Are you suggesting that we should name this file differently?
There was a problem hiding this comment.
Ok, as far as it is test scenario I think we can change it
|
+1 |
PR description:
Add modified PhaseI pixel barrel geometry xml's for 2017 scenario
PR validation:
Tested using a cfg file in Geometry/TrackerCommonData/test/python
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special