Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LHE HT and generator weights to TagAndProbe tree #32099

Merged
merged 2 commits into from Nov 19, 2020

Conversation

mseidel42
Copy link
Contributor

PR description:

Adding to TagAndProbe tree:

  • LHE HT for correct stitching of HT-binned samples
  • Weights for ME scale variations (can replace statistically limited MG vs aMCatNLO comparisons)
  • Weights for PS scale variations

PR validation:

Compiles in 11_2, no working EGM config available, unfortunately.

Validated and used in 10_2 (CMSSW_10_2_X...intrepid42:TnP_102X):

image

@jainshilpi

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32099/19750

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32099/19751

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

PhysicsTools/TagAndProbe

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@santocch
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: f9ee5eb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7e02e/10661/summary.html
CMSSW: CMSSW_11_2_X_2020-11-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7e02e/10661/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529273
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

do you have any comments @santocch ?

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 19, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants