Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving HGCal validation #32124

Merged
merged 13 commits into from Nov 13, 2020
Merged

Conversation

ebrondol
Copy link
Contributor

@ebrondol ebrondol commented Nov 12, 2020

PR description:

  • Enable the option --collection all to produce a list of collection with respective plots, while keeping the single collection option also available
  • Improve the visualisation of the validation for each collection with the creation of tables of plots
  • If --separate option is enable, each entry in the table will be converted to a link to a webpage which will displayed all plots separately. In order to do this, I have created SeparateValidation which is enable in the makeHGCalValidationPlots.py script.

PR validation:

  • I have verified that the code is still working in case the SimpleValidation is used with the --separate option.
  • Two examples of my development can be found in this folder using only the flag --collection all and in this other folder using --separate --collection allTiclMultiClusters

@ebrondol
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32124/19784

  • This PR adds an extra 92KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ebrondol (Erica Brondolin) for master.

It involves the following packages:

Validation/HGCalValidation
Validation/RecoTrack

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@vandreev11, @deguio, @sethzenz, @bsunanda, @makortel, @felicepantaleo, @wmtford, @GiacomoSguazzoni, @JanFSchulte, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak, @VinInn, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor

rovere commented Nov 12, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 12, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: f0b8900
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ed547/10697/summary.html
CMSSW: CMSSW_11_2_X_2020-11-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ed547/10697/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 13, 2020

+1

@cmsbuild cmsbuild merged commit 88a3c3e into cms-sw:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants