New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-gex36 Create 8 new scenarios for 2017 and 2018 with changed material budge in the tracker #32126
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32126/19785
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@bsunanda and @cvuosalo - why don't we have the Tracker material variations in a geometry dictionary and generate the scenarios from it? It is a maintenance burden to make scenarios by hand. They will diverge as soon as any improvement is integrated in the XML detector description. @kpedro88 - what do you think? |
@ianna I'm not sure it's worth further extending our geometry generation scripts to cover Run 2 (which is in principle finished). |
@ianna @kpedro88 If we have to define similar things for run3 - it will be done through dictionary. These are relevant for run2 scenarios.
…________________________________
From: Kevin Pedro [notifications@github.com]
Sent: 16 November 2020 18:23
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run2-gex36 Create 8 new scenarios for 2017 and 2018 with changed material budge in the tracker (#32126)
@ianna<https://github.com/ianna> I'm not sure it's worth further extending our geometry generation scripts to cover Run 2 (which is in principle finished).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#32126 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOQKV3ILMSLFHU7YSTDSQFNZHANCNFSM4TTOR3KQ>.
|
@kpedro88 Could you approve this? |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Create 8 new scenarios for 2017 and 2018 with changed material budge in the tracker
PR validation:
Tested using private test scripts - all the scenarios can be created
Nothing special