Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-gex36 Create 8 new scenarios for 2017 and 2018 with changed material budge in the tracker #32126

Merged
merged 1 commit into from Nov 17, 2020

Conversation

bsunanda
Copy link
Contributor

PR description:

Create 8 new scenarios for 2017 and 2018 with changed material budge in the tracker

PR validation:

Tested using private test scripts - all the scenarios can be created

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32126/19785

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 46db0e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23a1bb/10728/summary.html
CMSSW: CMSSW_11_2_X_2020-11-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23a1bb/10728/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529273
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@cvuosalo
Copy link
Contributor

+1

@ianna
Copy link
Contributor

ianna commented Nov 16, 2020

@bsunanda and @cvuosalo - why don't we have the Tracker material variations in a geometry dictionary and generate the scenarios from it? It is a maintenance burden to make scenarios by hand. They will diverge as soon as any improvement is integrated in the XML detector description.

@kpedro88 - what do you think?

@kpedro88
Copy link
Contributor

@ianna I'm not sure it's worth further extending our geometry generation scripts to cover Run 2 (which is in principle finished).

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 16, 2020 via email

@bsunanda
Copy link
Contributor Author

@kpedro88 Could you approve this?

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8d6455e into cms-sw:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants