Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConvertingESProducer(WithDependencies)T #32129

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 12, 2020

PR description:

Add a templated ConvertingESProducer[WithDependencies]T for use by ECAL and HCAL GPU ESProducers.

The templates are generic enough that thay could be used to implement any ESProducer that reads conditions data from a record and pushed derived conditions data in the same or a dependent record.
The current use case is to convert and copy the calibrations from the CPU to the GPUs.

PR validation:

Changes in use in the Patatrack releases.

If this PR is a backport please specify the original PR and why you need to backport that PR:

Includes changes from:

Add a templated ConvertingESProducer[WithDependencies]T for use by ECAL and
HCAL GPU ESProducers.

The templates are generic enough that thay could be used to implement any
ESProducer that reads conditions data from a record and pushed derived
conditions data in the same or a dependent record.
The current use case is to convert and copy the calibrations from the CPU
to the GPUs.

Co-authored-by: Viktor Khristenko <vdkhristenko1991@gmail.com>
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 12, 2020

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 12, 2020

+1

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32129/19793

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 12, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HeterogeneousCore/CUDACore

@cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 501edaf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5cc15/10715/summary.html
CMSSW: CMSSW_11_2_X_2020-11-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5cc15/10715/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529273
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

+1
@fwyzard it would be good to add a few lines as a description of the new classes (eg. https://github.com/cms-sw/cmssw/blob/master/HeterogeneousCore/CUDACore/interface/ContextState.h#L11)

@cmsbuild cmsbuild merged commit b33ca85 into cms-sw:master Nov 13, 2020
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 15, 2020

@fwyzard it would be good to add a few lines as a description of the new classes (eg. https://github.com/cms-sw/cmssw/blob/master/HeterogeneousCore/CUDACore/interface/ContextState.h#L11)

@silviodonato done via #32149 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants