[TF] Fix needed for tensorflow 2.3.1 #32131

smuzaffar · 2020-11-13T09:44:28Z

This change is needed to build cmssw with Tensorflow 2.3.1

>> Compiling  src/PhysicsTools/TensorFlow/src/TensorFlow.cc
In file included from src/PhysicsTools/TensorFlow/interface/TensorFlow.h:12,
                 from src/PhysicsTools/TensorFlow/src/TensorFlow.cc:9:
tensorflowe3b366e33aa8ec3622/include/tensorflow/core/framework/tensor.h: In instantiation of 'typename tensorflow::TTypes::Scalar tensorflow::Tensor::scalar() [with T = std::__cxx11::basic_string; typename tensorflow::TTypes::Scalar = Eigen::TensorMap, Eigen::Sizes<>, 1, long int>, 16, Eigen::MakePointer>]':
src/PhysicsTools/TensorFlow/src/TensorFlow.cc:143:39:   required from here
tensorflowe3b366e33aa8ec3622/include/tensorflow/core/framework/tensor.h:879:7: error: static assertion failed: std::string is no longer a scalar type, use tensorflow::tstring
       !std::is_same::value,
       ^~~~

smuzaffar · 2020-11-13T09:46:53Z

please test with cms-sw/cmsdist#6410

cmsbuild · 2020-11-13T09:50:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32131/19799

This PR adds an extra 12KB to repository

cmsbuild · 2020-11-13T09:51:11Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6410

CMSSW_11_2_X_2020-11-12-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10726/console Started: 2020/11/13 10:52

cmsbuild · 2020-11-13T09:51:14Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

PhysicsTools/TensorFlow

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @riga this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-11-13T18:43:36Z

+1
Tested at: 59dbc10
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-755816/10726/summary.html
CMSSW: CMSSW_11_2_X_2020-11-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-13T18:43:42Z

Comparison job queued.

cmsbuild · 2020-11-13T19:59:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-755816/10726/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529273
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 148 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-11-13T20:05:24Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6410
Test Parameters:

ARCHITECTURE_FILTER = slc7_aarch64_gcc820
CMSSW_11_2_X_2020-11-13-1100/slc7_aarch64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10748/console Started: 2020/11/13 21:06
CMSSW_11_2_X_2020-11-12-2300/slc7_ppc64le_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10749/console Started: 2020/11/13 21:09

cmsbuild · 2020-11-17T01:25:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c86be/10793/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529263
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 148 log files, 22 edm output root files, 35 DQM output files

slava77 · 2020-11-18T18:07:59Z

+1

for #32131 59dbc10

technical; differences in comparisons are apparently unrelated to the TF build

santocch · 2020-11-19T10:01:07Z

+1

cmsbuild · 2020-11-19T10:01:28Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-11-19T16:32:07Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6410,cms-sw/cmsdist#6429

CMSSW_11_2_X_2020-11-19-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10858/console Started: 2020/11/19 17:33

cmsbuild · 2020-11-19T19:04:29Z

+1
Tested at: 59dbc10
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c86be/10858/summary.html
CMSSW: CMSSW_11_2_X_2020-11-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-19T19:04:35Z

Comparison job queued.

cmsbuild · 2020-11-19T20:23:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c86be/10858/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8c86be/11624.911_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8c86be/11642.911_ZMM_13+2021_DD4hep+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2962300
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2962277
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 158 log files, 34 edm output root files, 37 DQM output files

smuzaffar · 2020-11-19T20:46:53Z

this looks good now., is there any thing else to check the performance of new TF 2.3.1?

silviodonato · 2020-11-20T08:25:55Z

+1

[TF] Fix needed fortensorflow 2.3.1

59dbc10

cmsbuild added this to the CMSSW_11_2_X milestone Nov 13, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Nov 13, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 13, 2020

cmsbuild mentioned this pull request Nov 13, 2020

[TF] updated to version 2.3.1 cms-sw/cmsdist#6410

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Nov 13, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 13, 2020

cmsbuild added comparison-available tests-started and removed comparison-pending tests-approved labels Nov 13, 2020

cms-sw deleted a comment from cmsbuild Nov 13, 2020

cmsbuild added the tests-approved label Nov 16, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 17, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 18, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Nov 19, 2020

cmsbuild added tests-started and removed tests-approved labels Nov 19, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Nov 19, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 19, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 20, 2020

cmsbuild merged commit e9ea0ce into cms-sw:master Nov 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TF] Fix needed for tensorflow 2.3.1 #32131

[TF] Fix needed for tensorflow 2.3.1 #32131

smuzaffar commented Nov 13, 2020 •

edited

smuzaffar commented Nov 13, 2020

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020 •

edited

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020 •

edited

cmsbuild commented Nov 17, 2020

slava77 commented Nov 18, 2020

santocch commented Nov 19, 2020

cmsbuild commented Nov 19, 2020

cmsbuild commented Nov 19, 2020 •

edited

cmsbuild commented Nov 19, 2020

cmsbuild commented Nov 19, 2020

cmsbuild commented Nov 19, 2020

smuzaffar commented Nov 19, 2020

silviodonato commented Nov 20, 2020

[TF] Fix needed for tensorflow 2.3.1 #32131

[TF] Fix needed for tensorflow 2.3.1 #32131

Conversation

smuzaffar commented Nov 13, 2020 • edited

smuzaffar commented Nov 13, 2020

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020 • edited

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020

cmsbuild commented Nov 13, 2020 • edited

cmsbuild commented Nov 17, 2020

slava77 commented Nov 18, 2020

santocch commented Nov 19, 2020

cmsbuild commented Nov 19, 2020

cmsbuild commented Nov 19, 2020 • edited

cmsbuild commented Nov 19, 2020

cmsbuild commented Nov 19, 2020

cmsbuild commented Nov 19, 2020

smuzaffar commented Nov 19, 2020

silviodonato commented Nov 20, 2020

smuzaffar commented Nov 13, 2020 •

edited

cmsbuild commented Nov 13, 2020 •

edited

cmsbuild commented Nov 13, 2020 •

edited

cmsbuild commented Nov 19, 2020 •

edited