Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding infra. for L1T object scaling constants from DB #32137

Merged
merged 1 commit into from Nov 25, 2020

Conversation

trtomei
Copy link
Contributor

@trtomei trtomei commented Nov 13, 2020

This PR adds initial infrastructure for the L1T-HLT interface for Phase2.
We add a new CondFormat for the L1TObjScalingConstants and a new DataRecord to hold that new format in a DB.

  • We added it to the standard test:
    CondFormats/HLTObjects/test/testSerializationHLTObjects.cpp

and ran scram b runtests with success!

  • We ran runTheMatrix.py -l limited -i all --ibeos with success.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32137/19806

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @trtomei (Thiago Tomei) for master.

It involves the following packages:

CondCore/HLTPlugins
CondFormats/DataRecord
CondFormats/HLTObjects

@cmsbuild, @yuanchao, @fwyzard, @christopheralanwest, @tocheng, @Martin-Grunewald, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 517538e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d812b9/10797/summary.html
CMSSW: CMSSW_11_2_X_2020-11-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d812b9/10797/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529261
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@yuanchao
Copy link
Contributor

+1

@ggovi
Copy link
Contributor

ggovi commented Nov 25, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants