Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE - TEST ONLY] Remove #31730 and #32021 from #31907 #32164

Closed
wants to merge 511 commits into from
Closed

[DO NOT MERGE - TEST ONLY] Remove #31730 and #32021 from #31907 #32164

wants to merge 511 commits into from

Conversation

silviodonato
Copy link
Contributor

PR description:

This PR is a copy of #31907 after having removed commits

The purpose of this PR is the review of #31907

andrius and others added 30 commits August 21, 2020 19:17
No more lumi in a PB file name
798e806 
This ensures that files get overwritten to save space
Zlib compressing ME blobs when saving PB files
62ace98 
This is required to bring the file size down without needing to
decompress the entire file when doing partial reads from the new DQM GUI
Using a run number from the configuration in Online DQM output filenames
7b99e12
Changed PB saver stream label saving new GUI live snapshots
4fce138
ZLib compressing QTest MEs as well (in DQM mode)
b1f6768
Fixed type name
e9d926c
@cmsbuild
Merge pull request cms-sw#31204 from mmusich/G4Refitting_updateBField…
b564a26 
…AtBeginRun_11_1_X

[11_1_X] update the B-Field configuration at beginRun in SimG4Core/GeometryProducer
@missirol
[Puppi] performance improvements
12d9fb9
@missirol
[Puppi] fixed comment
e02f54c
@missirol
[Puppi] removed comments
22b8692
@missirol
[Puppi] style change in var initialisation
166956b
@missirol
[Puppi] improved readability
444f651
@cmsbuild
Merge pull request cms-sw#31222 from fwyzard/add_boolean_modules
732729d 
Add modules to produce a boolean value, and filter based on it
@cmsbuild
Merge pull request cms-sw#31241 from missirol/devel_111X_puppi_speedup
0d9e613 
[11_1_X] improving performance of PuppiProducer
Added new DQM GUI support to the rest of the clients
487bbe3
@tlampen
Update phase2_realistic GT ; Use ideal pixel bad components and remov…
c97d935 
…e obsolete pixel tags
Fix deg to rad conversion
f032918
@cmsbuild
Merge pull request cms-sw#31323 from tlampen/update-phase2_realistic-…
241d1fe 
…in-autocond-backport

Use ideal pixel bad components and remove obsolete pixel tags for Phase-2 simulation (backport)
@christopheralanwest
Update Run 3 data GTs to those used in 2020 MWGR3
10b90a1
@cmsbuild
Merge pull request cms-sw#31392 from christopheralanwest/alca-mwgr3_2…
8719b10 
…020-11_1_X

Update Run 3 data GTs to those used in 2020 MWGR3 [11_1_X]
Use angle_units, deltaPhi
41dea91
@makortel
Sort comparison needs to be 'less than'
d41c5cf
@makortel
Combine the two sorts
8604bc8
@makortel
Replace predicate struct with lambda in std::unique call for complete…
ea02b13 
…ness
@cmsbuild
Merge pull request cms-sw#31430 from makortel/fixTTUTrackingAlg_111x
09da4e6 
Fix sorting in TTUTrackingAlg (11_1_X)
@Jingyan95 @cerminar
fix bug & adding cluster et as an option
341ae2a
@cerminar
fix syntax
bd1a6e0
@cerminar
code format
513cfca
@quark2
For backport
1c9da52
@cmsbuild
Merge pull request cms-sw#31342 from dildick/from-CMSSW_11_1_X_2020-0…
1f8462e 
…9-02-2300-fix-deg-to-rad-conversion

Fix deg to rad conversion in L1TkMuonProducer ("ManTra" version) for HLT TDR [11_1_X]
@silviodonato silviodonato changed the title [DO NOT MERGE - TEST ONLY] Remove from #31907 [DO NOT MERGE - TEST ONLY] Remove #31730 and #32021 from #31907 Nov 17, 2020
@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Nov 17, 2020
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32164/19866

ERROR: Build errors found during clang-tidy run.

Geometry/HGCalCommonData/interface/HGCalParameters.h:174:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Geometry/HGCalCommonData/interface/HGCalTypes.h:62:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Geometry/HGCalCommonData/interface/HGCalTypes.h:82:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Suppressed 2358 warnings (2349 in non-user code, 8 NOLINT, 1 with check filters).
--
Geometry/HGCalCommonData/interface/HGCalParameters.h:174:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Geometry/HGCalCommonData/interface/HGCalTypes.h:62:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Geometry/HGCalCommonData/interface/HGCalTypes.h:82:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Suppressed 2339 warnings (2330 in non-user code, 8 NOLINT, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending analysis-pending code-checks-rejected comparison-pending core-pending daq-pending db-pending dqm-pending generators-pending geometry-pending hlt-pending l1-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet