Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalDQM: Enabling hcalcalib to work under #31206 #32206

Merged
merged 1 commit into from Nov 21, 2020

Conversation

lwang046
Copy link
Contributor

Putting hcalcalib client into the list of modified clients in #31206 in preparation for the MWGR

PR validation:

local test shows hcalcalib client correctly saves the output DQM root using run338628.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lwang046 for CMSSW_11_1_X.

It involves the following packages:

DQM/Integration

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 20, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: cb84df4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecef5b/10890/summary.html
CMSSW: CMSSW_11_1_X_2020-11-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecef5b/10890/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 28 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 21, 2020

+1

@cmsbuild cmsbuild merged commit 7184bcf into cms-sw:CMSSW_11_1_X Nov 21, 2020
@jfernan2
Copy link
Contributor

@lwang046 since for next MWGR in February 2021 we will be using CMSSW_11_2_X, could you please forward port this PR to that branch so that changes tested over last MWGR do not get lost on the way?
Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants