Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added protection to Geant4e track propagator #32240

Merged
merged 1 commit into from Nov 23, 2020

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Nov 23, 2020

PR description:

Crash in Geant4e backward propagator #31920 stops final alignment of Run-2 based on data.
This PR allows to avoid the crash by applying a momentum limit on propagated tracks 1 GeV/c.

This modification should not affect release validation WFs.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR:

it is backport of #32239

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_10_6_X.

It involves the following packages:

TrackPropagation/Geant4e

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @JanFSchulte, @VinInn, @lecriste, @ebrondol, @mtosi this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Nov 23, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 23, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 1c39ec0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50b3a5/10947/summary.html
CMSSW: CMSSW_10_6_X_2020-11-22-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50b3a5/10947/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214712
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214376
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 26 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Nov 23, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 23, 2020

+1

@cmsbuild cmsbuild merged commit 8105937 into cms-sw:CMSSW_10_6_X Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants