Run3-sim77 Update the checking code for dd4hep vs ddd

[bsunanda]

PR description:

Update the checking code for dd4hep vs ddd

PR validation:

Used in checking the SimHit production for ECAL and HCAL

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32275/20059

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4CMS/Calo/test/python/dd4hep_SingleMuon_Step1_cfg.py modified in PR(s): Convert all remaining MessageLogger configurations to new syntax #32244
  • File SimG4CMS/Calo/test/python/ddd_SingleMuon_Step1_cfg.py modified in PR(s): Convert all remaining MessageLogger configurations to new syntax #32244

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32275/20059/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32275/20059/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32275/20059/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32275/20059/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32275/20060

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4CMS/Calo/test/python/dd4hep_SingleMuon_Step1_cfg.py modified in PR(s): Convert all remaining MessageLogger configurations to new syntax #32244
  • File SimG4CMS/Calo/test/python/ddd_SingleMuon_Step1_cfg.py modified in PR(s): Convert all remaining MessageLogger configurations to new syntax #32244

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

SimG4CMS/Calo

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-24-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11015/console Started: 2020/11/25 06:17

[cmsbuild]

+1
Tested at: 700efa2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17fb33/11015/summary.html
CMSSW: CMSSW_11_2_X_2020-11-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17fb33/11015/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2274 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2963516
• DQMHistoTests: Total failures: 54292
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2909202
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[civanch]

@bsunanda , do you have an explanation for regression. I would not expect change of results if it is only extension of geometry checks.

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-24-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11026/console Started: 2020/11/25 11:21

[silviodonato]

please test
I saw fake changes in other PR as well

eg. #32258 (comment)

[cmsbuild]

+1
Tested at: 700efa2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17fb33/11026/summary.html
CMSSW: CMSSW_11_2_X_2020-11-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17fb33/11026/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2282 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2963516
• DQMHistoTests: Total failures: 54303
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2909190
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[bsunanda]

@civanch I cannot think of any reason why this PR can affect regression results. The only changed code which appears in the workflows is ECalSD and the change refers to the change in the test code which does not affect regular workflows; ddd or dd4hep. So the changes if seen are due to other PR's

[silviodonato]

@bsunanda @civanch see #32283

[bsunanda]

@silviodonato @civanch Any difference in dd4hep workflow should be ignored as of now. Once dd4hep workflows are studied in detail differences in those workflows should be taken seriously.

[civanch]

@bsunanda , it is true for any other DD4Hep PR but for this one I am confused.

[civanch]

+1

I do not see how EcalSD modification can affect results, so let us ignore DD4Hep comparisons

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1