Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] feat: allow for not sorting during PATJetUpdater call #32298

Merged
merged 2 commits into from Dec 16, 2020

Conversation

andrzejnovak
Copy link
Contributor

Backport of #32297 needed for jetmet/btv nano production

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2020

A new Pull Request was created by @andrzejnovak (Andrzej Novak) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @JyothsnaKomaragiri, @ahinzmann, @smoortga, @schoef, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #32298 was updated. @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

backport of #32297

@santocch
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: be10da4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee0018/11141/summary.html
CMSSW: CMSSW_10_6_X_2020-11-29-0000
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee0018/11141/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214712
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214376
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 26 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

+1

  • As for the (basically identical) master version of this PR; it ended up that this will only involve some (private? future?) nanoAOD production, while the change is completely transparent to reco: let assign xpog for evaluating it, then
  • Jenkins tetst pass and show no differences wrt the baseline, as expected

@perrotta
Copy link
Contributor

assign xpog

@cmsbuild
Copy link
Contributor

New categories assigned: xpog

@fgolf,@mariadalfonso,@gouskos you have been requested to review this Pull request/Issue and eventually sign? Thanks

@santocch
Copy link

santocch commented Dec 4, 2020

+1

@andrzejnovak
Copy link
Contributor Author

Pinging @mariadalfonso in case the backport needs to be signed as well.

@mariadalfonso
Copy link
Contributor

+xpog
changes inline with master

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b2c2280 into cms-sw:CMSSW_10_6_X Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants