Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticleLevelProducer: check for leptonic decays of tag particles (106X) #32312

Merged
merged 1 commit into from Nov 30, 2020

Conversation

mseidel42
Copy link
Contributor

PR description:

Adds lepton+neutrino daughters of jet tag particles (heavy hadrons) to allow for calculation and correction of semileptonic branching ratios.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #32310 for TOP analysis

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2020

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_10_6_X.

It involves the following packages:

GeneratorInterface/RivetInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Nov 27, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: db1a3fe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-527eec/11106/summary.html
CMSSW: CMSSW_10_6_X_2020-11-27-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-527eec/11106/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214712
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214377
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 26 edm output root files, 34 DQM output files

@agrohsje
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

Backport of #32310

@silviodonato
Copy link
Contributor

backport of #32310

@qliphy
Copy link
Contributor

qliphy commented Nov 30, 2020

+1

@cmsbuild cmsbuild merged commit eadf88e into cms-sw:CMSSW_10_6_X Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants