Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store energy fractions of gammas in packedPFCandidates (10_6_X) #32314

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Nov 27, 2020

PR description:

This PR adds energy fractions of PFGammas (PFCandidates with pdgId==22) to packedPFCandidate collection in miniAOD. This completes information needed to build tau quantities based on energy fractions of its constituents.

The addition is triggered only for UL re-miniAOD by run2_miniAOD_UL modifier.

Size increase estimated in the original PR with ttbar sample with PU is as follows:

  • total size: +0.14% or +107 bytes/event,
  • packedPFCandidates: +0.3%.

This PR is a partial backport of #30571. Changes other than energy fraction of PFGammas contained in the original PR can be a subject of another backport PR to 10_6_X series, but as they are not affecting event content will be postponed for more peaceful time.

PR validation:

Tested with standard miniAOD workflow with run2_miniAOD_UL modifier.

if this PR is a backport please specify the original PR and why you need to backport that PR:

It is a partial backport of #30571, needed for UL re-miniAOD production as agreed with XPOG.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @JyothsnaKomaragiri, @ahinzmann, @smoortga, @schoef, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Nov 27, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 94e12aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2da63a/11105/summary.html
CMSSW: CMSSW_10_6_X_2020-11-27-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2da63a/11105/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214712
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214377
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 26 edm output root files, 34 DQM output files

@santocch
Copy link

+1

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2020

+1

for #32314 94e12aa

  • code changes are in line with the PR description.
    • The changes in this PR are partly from Updates for TauReco at miniAOD #30571 (parts of 0d4f18f and 54785f1).
    • In addition, a new parameter storePfGammaEnFractions is added only for 10_6_X and it's enabled only with run2_miniAOD_UL. I do not see a need for this parameter to be in the master branch.
  • jenkins tests pass and comparisons with the baseline show a change in the caloFraction in the UL re-miniAOD workflow 136.88811, as expected more non-zero values are now filled
    all_OldVSNew_RunJetHT2018DreMINIAODULwf136p88811c_patPackedCandidates_packedPFCandidates__PAT_obj_caloFraction

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 2, 2020

+1

@cmsbuild cmsbuild merged commit e7a551b into cms-sw:CMSSW_10_6_X Dec 2, 2020
@mbluj mbluj deleted the CMSSW_10_6_X_tau-pog_pfGammaEnFr branch October 10, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants