Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the fillDescriptions method for RawStreamFileWriterForBU (11.2.x) #32323

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 28, 2020

PR description:

Implement the fillDescriptions() method for the RawStreamFileWriterForBU module.
Clean up the module's parameters and directly use an InputTag in the python configuration.

PR validation:

None.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #32284

Clean up the module's parameters and directly use an InputTag in the
python configuration.

Update the startBU.py script accordingly.
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 28, 2020

backport #32284

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Nov 28, 2020
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 28, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_2_X.

It involves the following packages:

EventFilter/Utilities

@perrotta, @emeschi, @cmsbuild, @slava77, @jpata, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 2e2b420
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a7ac0/11131/summary.html
CMSSW: CMSSW_11_2_X_2020-11-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smorovic
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a7ac0/11131/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2746985
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 34 edm output root files, 36 DQM output files

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2020

+1

for #32323 2e2b420

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard fwyzard changed the title Implement the fillDescriptions method for RawStreamFileWriterForBU Implement the fillDescriptions method for RawStreamFileWriterForBU (11.2.x) Dec 1, 2020
@qliphy
Copy link
Contributor

qliphy commented Dec 1, 2020

+1

@cmsbuild cmsbuild merged commit 9479aff into cms-sw:CMSSW_11_2_X Dec 1, 2020
@fwyzard fwyzard deleted the implement_RawStreamFileWriterForBU_fillDescriptions branch December 27, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants