Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression Test Update #3234

Merged
merged 3 commits into from Apr 7, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Apr 7, 2014

  • Use up-to-date geometry list for tests
  • Fix Pilot blade description: logical volumes were defined, but physical volumes were not.
  • Remove duplicate and obsolete cms.xml from Tracker directory. The top level from CMSCommonData should be used if needed.

@ianna
Copy link
Contributor Author

ianna commented Apr 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@ianna
Copy link
Contributor Author

ianna commented Apr 7, 2014

@friccita - please, update your local copy of Pilot blade definition. There were two logical volume definitions left while the shapes were commented out. It's fixed in this PR.

@ktf
Copy link
Contributor

ktf commented Apr 7, 2014

This currently fails. Bypassing tests to get it into the 1400 IB.

ktf added a commit that referenced this pull request Apr 7, 2014
Geometry -- Regression Test Update
@ktf ktf merged commit 7601c8c into cms-sw:CMSSW_7_1_X Apr 7, 2014
@ianna ianna deleted the regression-test-update branch October 26, 2015 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants