Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race conditions in the PluginSystem #32359

Merged
merged 1 commit into from Dec 2, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Use tbb::zero_allocator to be sure std::atomic is nullptr even before its constructor has finished
  • Avoid having a temporary empty std::shared_ptr be placed in the map before being reset
  • Be sure object is fully initialized before using it

PR validation:

Framework unit tests all pass.

- Use tbb::zero_allocator to be sure std::atomic is nullptr even before its constructor has finished
- Avoid having a temporary empty std::shared_ptr be placed in the map before being reset
- Be sure object is fully initialized before using it
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32359/20203

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/PluginManager

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+1
Tested at: 82c4e10
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7019a/11234/summary.html
CMSSW: CMSSW_11_3_X_2020-12-01-1100
SCRAM_ARCH: slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7019a/11234/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7019a/11234/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7019a/11234/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529564
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@makortel
Copy link
Contributor

makortel commented Dec 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 2, 2020

+1

@cmsbuild cmsbuild merged commit b79a220 into cms-sw:master Dec 2, 2020
@Dr15Jones Dr15Jones deleted the fixRaceConditionInPluginSystem branch December 2, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants