New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Tracker Alignment PV Validation to work with phase-2 geometries #32363
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32363/20208
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/OfflineValidation @cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The goal of this PR is to adapt the Tracker Alignment PV Validation tool to be able to cope with Phase-2 Tracker geometries.
The main things which are changed are:
Shown here for reference is the layout of the T15 (included in the D49) geometry, as used for the Phase-2 HLT TDR:
PR validation:
Relies on the existing unit tests.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport is needed.