Make the skipBadFiles option work, add tests

[wddgit]

PR description:

Bug fix. Make the skipBadFiles option work. I suspect this option was not being used at all given the number of problems with it and the lack of a good unit test... Anyway, this fixes it. I noticed this while testing ProcessBlock persistence (not from a user report). PoolInputTest_skip_with_failure_cfg.py was failing with the new ProcessBlock code.

PR validation:

Added a new unit test. Also, fixed the unit test that creates an empty file. That used to work by using EmptySource and setting maxEvents to zero, but now that does not create any output files at all. Now the fixed unit test uses PoolSource and selects only lumis not in the input file.

As far as I know, RelVal type tests do not use the skipBadFiles option so this should not affect them.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32373/20219

ERROR: Build errors found during clang-tidy run.

FWCore/Framework/interface/EventProcessor.h:326:31: error: field type 'edm::PathsAndConsumesOfModules' is an abstract class [clang-diagnostic-error]
    PathsAndConsumesOfModules pathsAndConsumesOfModules_;
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02657/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_11_3_X_2020-12-02-1100/src/FWCore/ServiceRegistry/interface/PathsAndConsumesOfModulesBase.h:83:58: note: unimplemented pure virtual method 'doModulesWhoseProductsAreConsumedBy' in 'PathsAndConsumesOfModules'
--
FWCore/Framework/interface/PathsAndConsumesOfModules.h:54:71: error: non-virtual member function marked 'override' hides virtual member function [clang-diagnostic-error]
        unsigned int moduleID, BranchType branchType = InEvent) const override;
                                                                      ^
/cvmfs/cms-ib.cern.ch/nweek-02657/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_11_3_X_2020-12-02-1100/src/FWCore/ServiceRegistry/interface/PathsAndConsumesOfModulesBase.h:83:58: note: hidden overloaded virtual function 'edm::PathsAndConsumesOfModulesBase::doModulesWhoseProductsAreConsumedBy' declared here: different number of parameters (1 vs 2)
--
FWCore/Framework/interface/PathsAndConsumesOfModules.h:58:44: error: only virtual member functions can be marked 'override' [clang-diagnostic-error]
    unsigned int doLargestModuleID() const override;
                                           ^~~~~~~~
FWCore/Framework/src/SubProcess.h:288:31: error: field type 'edm::PathsAndConsumesOfModules' is an abstract class [clang-diagnostic-error]
    PathsAndConsumesOfModules pathsAndConsumesOfModules_;
                              ^
Suppressed 1776 warnings (1775 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[wddgit]

code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32373/20224

• This PR adds an extra 8KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Framework
IOPool/Input

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_3_X_2020-12-02-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11287/console Started: 2020/12/03 07:12

[cmsbuild]

+1
Tested at: 2f09bc8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4f4ba/11287/summary.html
CMSSW: CMSSW_11_3_X_2020-12-02-2300
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4f4ba/11287/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529570
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 37 edm output root files, 35 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1