Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JEC for 2018 HI re-miniAOD #32375

Merged
merged 2 commits into from Dec 8, 2020
Merged

Conversation

christopheralanwest
Copy link
Contributor

@christopheralanwest christopheralanwest commented Dec 3, 2020

PR description:

This PR updates the HI JEC for the re-miniAOD of the 2018 HI run. The 2018 HI MC as well as the 2018 HI IOVs of the prompt-like data JEC tags are updated. The GT diffs are as follows:

Prompt-like data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_PromptLike_HI_v3/112X_dataRun2_PromptLike_HI_v5

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HI_v5/112X_upgrade2018_realistic_HI_v6

PR validation:

See the HN thread for details. In addition, a technical test was performed: runTheMatrix.py -l limited --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but will be backported to 11_2_X as it is intended for use in 11_2_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32375/20225

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2020

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2020

-1

Tested at: d8f8963

CMSSW: CMSSW_11_3_X_2020-12-02-2300
SCRAM_ARCH: slc7_amd64_gcc900
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73b709/11288/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Thu Dec 3 08:43:24 2020-date Thu Dec 3 08:36:53 2020 s - exit: 16640

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73b709/11288/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 36 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 245
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529326
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32375/20272

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

Pull request #32375 was updated. @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73b709/11402/summary.html
CMSSW: CMSSW_11_3_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73b709/11402/summary.html
CMSSW: CMSSW_11_3_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 36 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 242
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2746750
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 8, 2020

+1

@cmsbuild cmsbuild merged commit e0edf22 into cms-sw:master Dec 8, 2020
@mandrenguyen
Copy link
Contributor

Hi @christopheralanwest
Can you backport this to 11_2_X?

@christopheralanwest
Copy link
Contributor Author

Hi @christopheralanwest
Can you backport this to 11_2_X?

I've created the backport PR #32453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants