Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 he27 #3238

Merged
merged 1 commit into from Apr 8, 2014
Merged

Phase2 he27 #3238

merged 1 commit into from Apr 8, 2014

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Apr 7, 2014

Small fix in HcalTopology and making a few scripts operational

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2014

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase2 he27

It involves the following packages:

Geometry/CaloTopology
SimG4Core/Geometry
SimG4Core/PrintGeomInfo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

Ready to merge once we get the go ahead from geometry.
Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Tests 12200, 12400, 12600, 13200, 13400, 13800, 14000, 14200 and 14400 fail in step 2 with known errors.

@ianna
Copy link
Contributor

ianna commented Apr 8, 2014

+1

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Apr 8, 2014
@cmsbuild cmsbuild merged commit cedddcf into cms-sw:CMSSW_6_2_X_SLHC Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants