Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] backport of 32339 and 32371 to assure thread-safe dd4hep workflow #32388

Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Dec 4, 2020

PR description:

PR validation:

@qliphy - as requested

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Dec 4, 2020
@ianna
Copy link
Contributor Author

ianna commented Dec 4, 2020

backport of #32339
backport of #32371

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_11_2_X.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/TrackerCommonData
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder
SimG4Core/DD4hepGeometry
SimG4Core/Geometry

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @rovere, @VinInn, @ebrondol, @ghugo83, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Dec 4, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc2972/11336/summary.html
CMSSW: CMSSW_11_2_X_2020-12-04-1100
SCRAM_ARCH: slc7_amd64_gcc900

@ianna
Copy link
Contributor Author

ianna commented Dec 4, 2020

please test workflow 11624.911, 11642.911

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc2972/11340/summary.html
CMSSW: CMSSW_11_2_X_2020-12-04-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc2972/11340/summary.html
CMSSW: CMSSW_11_2_X_2020-12-04-1100
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529564
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Dec 4, 2020

+1

@civanch
Copy link
Contributor

civanch commented Dec 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 5, 2020

+1

@cmsbuild cmsbuild merged commit 1bf1cc0 into cms-sw:CMSSW_11_2_X Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants