Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates (backport to 11_2_X)

[hatakeyamak]

PR description:

This backport addresses PF to run with recent HGCAL update #31907. More in detail this will allow ChargedHadronPFTrackIsolationProducer to accommodate PF candidates which don't go through the PFBlock mechanism.

PR validation:

For more validation, see the original PR #32202.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #32202.

@bendavid @rovere @felicepantaleo @hqucms

[cmsbuild]

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for CMSSW_11_2_X.

It involves the following packages:

RecoParticleFlow/PFProducer

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @cbernet this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates #32202

[perrotta]

backport of #32202

[perrotta]

please test

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea95d/11345/summary.html
CMSSW: CMSSW_11_2_X_2020-12-04-1100
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea95d/11345/summary.html
CMSSW: CMSSW_11_2_X_2020-12-04-1100
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529564
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 37 edm output root files, 35 DQM output files

[perrotta]

+1

• Identical backport of Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates #32202, identical comments wrt the ones left in the master follow
• The fix is effective for the charged pfTICL candidates
• They are all automatically considered as being "isolated": in any case, charged isolation is said not to be relevant for PF candidates from TICL
• Jenkins tests pass and show no differences in standard workflows (i.e. the ones for which injectTICLintoPF is not specified)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

PS: in order to speed up the approval, I do not add the explicit request of "upgrade" signature here. Kevin already signed the identical PRs in the master and in 11_1_X (#32316), and he was the one that actually requested this backport in 11_"_X (see #32202 (comment))
Off course, feel free to assign also "upgrade" here and wait for @kpedro88 signing it

[silviodonato]

+1