Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu migration to 11_2_0_pre11 template #32402

Merged
merged 3 commits into from Dec 8, 2020

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Dec 7, 2020

PR description:

HLT menu migration to 11_2_0_pre11 template
Based on CMSSW_11_2_0_pre11

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Dec 7, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_11_2_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@Martin-Grunewald Martin-Grunewald changed the title HLT menu migration to11_2_0_pre11 template HLT menu migration to 11_2_0_pre11 template Dec 7, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bd0ae/11393/summary.html
CMSSW: CMSSW_11_2_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bd0ae/11393/summary.html
CMSSW: CMSSW_11_2_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529589
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529560
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

@Martin-Grunewald do you have the PR for the master branch too?

@Martin-Grunewald
Copy link
Contributor Author

@silviodonato
This PR does not apply to the 113x master as it has diverged already. There will be one to migrate the menus to 1130pre1 for 113x.

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 10f3aff into cms-sw:CMSSW_11_2_X Dec 8, 2020
@Martin-Grunewald Martin-Grunewald deleted the HLTmigrationTo1120pre11 branch October 27, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants