Run3-gex43 Remove double declaration of the same constant

[bsunanda]

PR description:

Remove double declaration of the same constant

PR validation:

Use cfg's in some test areas

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32407/20275

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/CMSCommonData
SimG4Core/Configuration

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @slomeo, @fabiocos, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

+1

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90a21b/11412/summary.html
CMSSW: CMSSW_11_3_X_2020-12-06-2300
SCRAM_ARCH: slc7_amd64_gcc900

[civanch]

+1

[ianna]

@bsunanda - It seems like a significant change. Are you sure that increasing the thickness by 0.5 mm corresponds to the engineering drawing and does not introduce new overlaps?

[cmsbuild]

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90a21b/11412/summary.html
CMSSW: CMSSW_11_3_X_2020-12-06-2300
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2747014
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2746985
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[kpedro88]

+upgrade

[cmsbuild]

Pull request #32407 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[bsunanda]

@ianna @cvuosalo I did not increase the value - just removed the irrelevant value - the second constant in the files were more relevant. I checked it in earlier drawing files. More recent file has a slightly different value which comes in v3/v...

[bsunanda]

@cmsbuild Please test

[cvuosalo]

unhold

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90a21b/11471/summary.html
CMSSW: CMSSW_11_3_X_2020-12-09-1100/slc7_amd64_gcc900

[cmsbuild]

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90a21b/11471/summary.html
CMSSW: CMSSW_11_3_X_2020-12-09-1100/slc7_amd64_gcc900

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2747014
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2746985
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[cvuosalo]

+1

[civanch]

+1

[ianna]

@ianna @cvuosalo I did not increase the value - just removed the irrelevant value - the second constant in the files were more relevant. I checked it in earlier drawing files. More recent file has a slightly different value which comes in v3/v...

Thanks @bsunanda! Just wanted to confirm, because, if there are two constants defined, one would need to check which one is taken into consideration: the first or the latter. If it's the first, removing it would change the constant value.

  <Constant name="BeampipeThickness4" value="2.0*mm"/>
  <Constant name="BeampipeThickness4" value="2.5*mm"/>

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1