Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote module deletion printout to INFO #32410

Merged
merged 1 commit into from Dec 8, 2020

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 8, 2020

PR description:

#29553 included a WARNING level printout for the modules being deleted to aid debugging of possible problems in IBs. Such problems have not appeared after several days, so I think it is safe to demote the printout to INFO (as anticipated in #29553 (comment))

After #32244 gets merged, the list of deleted modules can be printed with

process.MessageLogger.cerr.threshold = "INFO"
process.MessageLogger.cerr.DeleteModules = dict()

PR validation:

Workflow 25.0 step3 is clean from the printout present in the IB.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32410/20279

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Framework

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Dec 8, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c056ab/11414/summary.html
CMSSW: CMSSW_11_3_X_2020-12-07-2300
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c056ab/11414/summary.html
CMSSW: CMSSW_11_3_X_2020-12-07-2300
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2746985
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@makortel
Copy link
Contributor Author

makortel commented Dec 8, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ab41cc2 into cms-sw:master Dec 8, 2020
@makortel
Copy link
Contributor Author

makortel commented Dec 8, 2020

@cms-sw/reconstruction-l2 On a cursory look vast majority of "modules deleted because of no consumers" are in RECO+MiniAOD step (things like ak4CaloL1FastL2L3Corrector, elPFIsoValueCharged03NoPFIdPAT, muPFIsoValueCharged03PAT, patPFMetT0pc, pileupJetIdCalculator, tauIsoDepositPFCandidates). Would it be worth of the effort to follow up on these? (I have a copy of full matrix logs from IB, but I won't bother with further processing if there is no interest to follow up the results)

@makortel makortel deleted the demotePrintout branch December 8, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants