Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax warnings in matrix code #32419

Merged
merged 1 commit into from Dec 9, 2020
Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Dec 8, 2020

PR description:

There were a few syntax warnings from the python3 checks (pointed out by @jpata in #32128 (comment)):

src/Configuration/PyReleaseValidation/python/MatrixUtil.py:120: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(self.run) is not 0 or self.ls:
src/Configuration/PyReleaseValidation/python/MatrixUtil.py:187: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(self.run) is not 0:
src/Configuration/PyReleaseValidation/python/relval_upgrade.py:42: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if (specialType is not 'baseline') and ( ('PU' in step and step.replace('PU','') in specialWF.PU) or (step in specialWF.steps) ):

These are now fixed.

PR validation:

runTheMatrix.py still works.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32419/20285

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Dec 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc4c0e/11425/summary.html
CMSSW: CMSSW_11_3_X_2020-12-08-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc4c0e/11425/summary.html
CMSSW: CMSSW_11_3_X_2020-12-08-1100
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2746985
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@kpedro88
Copy link
Contributor Author

kpedro88 commented Dec 8, 2020

+upgrade

@chayanit
Copy link

chayanit commented Dec 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 9, 2020

+1

@cmsbuild cmsbuild merged commit d82082a into cms-sw:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants