EgHLT Phase-II showershape fix : 11_2_X

[Sam-Harper]

PR description:

This PR disables the calculation of ECAL showershape variables for superclusters which are not in the ECAL. It sets the showershapes to zero so that by default they pass, this makes things easier to build a trigger as it avoids having to OR the ECAL and HGCAL showershape filters (which likely eventually will be made into a single filter but that is not for today).

No physics changes are expected, the change in behaviour is a crash is prevented for PhaseII

PR validation:

PhaseII E/gamma HLT workflows do not crash.

if this PR is a backport please specify the original PR and why you need to backport that PR:

#32469: bug fix to run E/gamma HLT Phase-II

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_11_2_X.

It involves the following packages:

RecoEgamma/EgammaHLTProducers

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@sobhatta, @jainshilpi, @Fedespring, @lgray, @calderona, @HuguesBrun, @afiqaize, @varuns23, @cericeci, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from EgHLT Phase-II showershape fix : 11_3_X #32469

[fwyzard]

@cmsbuild, please test

[cmsbuild]

Pull request #32470 was updated. @Martin-Grunewald, @cmsbuild, @fwyzard can you please check and sign again.

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-591a0b/11730/summary.html
CMSSW: CMSSW_11_2_X_2020-12-15-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529570
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 37 edm output root files, 35 DQM output files

[Martin-Grunewald]

+1

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

backport of #32469

[silviodonato]

+1