Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins for Phase-2 L1T-HLT (11.1.x backport) #32474

Merged
merged 1 commit into from Dec 16, 2020

Conversation

trtomei
Copy link
Contributor

@trtomei trtomei commented Dec 14, 2020

backport of #32454

This PR adds additional infrastructure for the L1T-HLT interface for Phase2.
It is a sister PR to #32425 .
We add a set of modules to implement selections on the L1T Phase-2 candidates

We ran scram b runtests with success.

We ran runTheMatrix.py -l limited -i all --ibeos with success.

And the test/test_Phase2L1THLT.py that we added runs succesfully!

$ cmsRun test_Phase2L1THLT.py
14-Dec-2020 15:05:52 CET  Initiating request to open file root://eoscms.cern.ch//eos/cms/store/mc/Phase2HLTTDRSummer20ReRECOMiniAOD/DYToLL_M-50_TuneCP5_14TeV-pythia8/FEVT/PU200_pilot_111X_mcRun4_realistic_T15_v1-v1/270000/FF7BF0E2-1380-2D48-BB19-F79E6907CD5D.root
%MSG-w XrdAdaptor:  file_open 14-Dec-2020 15:05:55 CET pre-events
Data is served from cern.ch instead of original site eoscms
%MSG
14-Dec-2020 15:06:10 CET  Successfully opened file root://eoscms.cern.ch//eos/cms/store/mc/Phase2HLTTDRSummer20ReRECOMiniAOD/DYToLL_M-50_TuneCP5_14TeV-pythia8/FEVT/PU200_pilot_111X_mcRun4_realistic_T15_v1-v1/270000/FF7BF0E2-1380-2D48-BB19-F79E6907CD5D.root
Begin processing the 1st record. Run 1, Event 194609, LumiSection 1113 on stream 0 at 14-Dec-2020 15:06:23.501 CET
Begin processing the 2nd record. Run 1, Event 194605, LumiSection 1113 on stream 0 at 14-Dec-2020 15:06:25.834 CET
...
TrigReport ---------- Module Summary ------------
TrigReport    Visited   Executed     Passed     Failed      Error Name
TrigReport        175        175        175          0          0 HLT_DoubleMu7_DZ0p33
TrigReport        175        175        175          0          0 HLT_HT90
TrigReport        175        175        175          0          0 HLT_MET90
TrigReport        175        175        175          0          0 HLT_MHT40
TrigReport        175        175        175          0          0 HLT_SingleEle7
TrigReport        175        175        175          0          0 HLT_SingleIsoEle7
TrigReport        175        175        175          0          0 HLT_SingleIsoPhoton7
TrigReport        175        175        175          0          0 HLT_SingleJet64
TrigReport        175        175        175          0          0 HLT_SingleMu7
TrigReport        350        175        175          0          0 L1PFHtMht
TrigReport        175        175        175          0          0 TriggerResults
TrigReport        175        175         20        155          0 l1tDoubleMuon7
TrigReport         20         20         19          1          0 l1tDoubleMuon7DZ0p33
TrigReport        175        175         68        107          0 l1tEle7
TrigReport        175        175         60        115          0 l1tIsoEle7
TrigReport        175        175        107         68          0 l1tIsoPho7
TrigReport        175        175         38        137          0 l1tMuon7
TrigReport        175        175         72        103          0 l1tPFHt90
TrigReport        175        175        117         58          0 l1tPFJet64
TrigReport        175        175         93         82          0 l1tPFMet90
TrigReport        175        175         67        108          0 l1tPFMht40

Only missing in the test are the flavours of L1T PFTau (l1t::PFTau and l1t::HPSPFTau), because we don't have samples with those objects yet.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 14, 2020

A new Pull Request was created by @trtomei (Thiago Tomei) for CMSSW_11_1_X.

It involves the following packages:

HLTrigger/HLTfilters
HLTrigger/JetMET

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

@kpedro88 please feel free to assign this PR to upgrade

@Martin-Grunewald
Copy link
Contributor

please test

@Martin-Grunewald
Copy link
Contributor

@trtomei
No backport to 11_2?

@trtomei
Copy link
Contributor Author

trtomei commented Dec 15, 2020

@Martin-Grunewald No need to backport to 11_2. The TDR is made with 11_1, and we expect that after that all development moves to the latest and greatest (11_3 or beyond).

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3e6d5/11686/summary.html
CMSSW: CMSSW_11_1_X_2020-12-13-0000/slc7_amd64_gcc820

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784775
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

urgent
for the HLT TDR release (11_1_X)

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 04f93c2 into cms-sw:CMSSW_11_1_X Dec 16, 2020
@trtomei trtomei deleted the PR-111X-HLTL1TPlugins branch January 26, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants