Use esConsumes with SiPixelStatusProducer

[Dr15Jones]

PR description:

• added use of esConsumes
• regenerate SiPixelTopoFinder on each Run boundary rather than try to allow reuse to simplify code and decouple from use of SerialTaskQueue. This should have no performance effect as concurrent Runs are not yet supported in the framework and when they are implemented very, very few workflows will ever cross Run boundaries.

PR validation:

The code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32484/20390

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibTracker/SiPixelQuality

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e87d46/11640/summary.html
CMSSW: CMSSW_11_3_X_2020-12-14-1100/slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• HBHE: Avoid double counting of correlated term #32394 @mariadalfonso: HBHE: Avoid double counting of correlated term
• Phase2 improved conditions and ntuple maker update #32220 @OzAmram: Phase2 improved conditions and ntuple maker update
• Revert "Adding infra. for L1T object scaling constants from DB" #32436 @cms-sw: Revert "Adding infra. for L1T object scaling constants from DB"

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e87d46/11640/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e87d46/11640/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8127 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2747284
• DQMHistoTests: Total failures: 58200
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2689061
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e87d46/11680/summary.html
CMSSW: CMSSW_11_3_X_2020-12-15-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2747284
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2747255
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[christopheralanwest]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

merge