Added "/dd4hep::cm" to the DTGeometryBuilder Class #32485

slomeo · 2020-12-14T19:25:34Z

PR description:

Added "/ ddhep::cm" to the DD4hep part of the DTGeometryBuilder Class in order to simplify a possible future unit transition

PR validation:

validation by "cmsRun Geometry/RPCGeometryBuilder/test/python/validateDTGeometry_cfg.py" and "cmsRun Geometry/RPCGeometryBuilder/test/python/validateDTGeometryDDD_cfg.py"

See attached picture (only one histo for DD4hep)

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

validation by printouts (myLog.log), for both DD & DD4Hep, created by the validation scripts used above (for example please see, below, the parameters check for the 574914560 (Chamber) detid, 574922752 (SLayer) detid, 574923776 (Layer) detid ):

//DDD

(0) DTGeometryBuilder - DDD
(1) detId: 574914560, par[0]: 1090 mm, par[1]: 1255.5 mm, par[2]: 181 mm
(2) detId: 574922752, par[0]: 1063.2 mm, par[1]: 1255.5 mm, par[2]: 26.75 mm
(3) detId: 574923776, par[0]: 1029.65 mm, par[1]: 1199 mm, par[2]: 5.75 mm
(4) detId: 574923776 ,wireLenght in ddd, (wpar[1] in dd4hep): 117.4 cm, firstWire: 1

//DD4Hep

(0) DTGeometryBuilder - DD4Hep
(1) detId: 574914560, par[0]: 109 cm, par[1]: 125.55 cm, par[2]: 18.1 cm
(2) detId: 574922752, par[0]: 106.32 cm, par[1]: 125.55 cm, par[2]: 2.675 cm
(3) detId: 574923776, par[0]: 102.965 cm, par[1]: 119.9 cm, par[2]: 0.575 cm
(4) detId: 574923776, wpar[1]: 117.4 cm, firstWire: 1
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

validation by "runTheMatrix.py -l 25202.1" :

25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Mon Dec 14 18:32:47 2020-date Mon Dec 14 18:10:42 2020; exit: 0 0 0 0 1 1 1 1 tests passed, 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

cmsbuild · 2020-12-14T19:34:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32485/20391

This PR adds an extra 16KB to repository

cmsbuild · 2020-12-14T19:35:15Z

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Geometry/DTGeometryBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cvuosalo · 2020-12-14T21:27:39Z

@cmsbuild please test

cvuosalo · 2020-12-14T21:32:45Z

Geometry/DTGeometryBuilder/plugins/dd4hep/DTGeometryBuilder.cc

@@ -50,6 +51,8 @@ using namespace std;
 using namespace cms;

 void DTGeometryBuilder::buildGeometry(DDFilteredView& fview, DTGeometry& geom, const MuonGeometryConstants& num) const {
+  edm::LogVerbatim("DTGeometryBuilder") << "(0) DTGeometryBuilder - DD4Hep ";
+


It looks like line 89 also needs conversion:

new Plane(Surface::PositionType(tr[0], tr[1], tr[2]),

I believe these are positions in cm.

cvuosalo · 2020-12-14T21:34:07Z

Geometry/DTGeometryBuilder/src/DTGeometryBuilderFromDD4Hep.cc

@@ -49,6 +50,8 @@ using namespace std;
 void DTGeometryBuilderFromDD4Hep::buildGeometry(cms::DDFilteredView& fview,
                                                DTGeometry& geom,
                                                const MuonGeometryConstants& num) const {
+  edm::LogVerbatim("DTGeometryBuilder") << "(0) DTGeometryBuilder - DD4Hep ";
+


Same translation problem here, same line 89.

@cvuosalo : done

cmsbuild · 2020-12-15T00:19:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adf07b/11645/summary.html
CMSSW: CMSSW_11_3_X_2020-12-14-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2747284
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2747255
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 153 log files, 37 edm output root files, 36 DQM output files

cmsbuild · 2020-12-15T11:22:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32485/20412

This PR adds an extra 20KB to repository

cmsbuild · 2020-12-15T11:23:15Z

Pull request #32485 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

civanch · 2020-12-15T12:59:31Z

please test

cmsbuild · 2020-12-15T15:49:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adf07b/11676/summary.html
CMSSW: CMSSW_11_3_X_2020-12-15-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2747284
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2747261
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 153 log files, 37 edm output root files, 36 DQM output files

cvuosalo · 2020-12-15T20:31:55Z

+1

cmsbuild · 2020-12-15T20:32:15Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-12-16T00:25:26Z

+1

added /dd4hep::cm to DTGeometryBuilder

de7ecc1

cmsbuild added this to the CMSSW_11_3_X milestone Dec 14, 2020

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending labels Dec 14, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 14, 2020

cmsbuild added tests-started and removed tests-pending labels Dec 14, 2020

cvuosalo reviewed Dec 14, 2020

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Dec 15, 2020

fixed /dd4hep::cms in plane method

b2993c7

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Dec 15, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 15, 2020

cmsbuild removed the tests-pending label Dec 15, 2020

cmsbuild added the tests-started label Dec 15, 2020

cmsbuild added tests-approved and removed tests-started labels Dec 15, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Dec 15, 2020

cmsbuild added orp-approved and removed orp-pending labels Dec 16, 2020

cmsbuild merged commit 427b63e into cms-sw:master Dec 16, 2020

slomeo mentioned this pull request Jul 27, 2021

[DD4hep] DT geometry builder unit test does not fail when it should #29206

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added "/dd4hep::cm" to the DTGeometryBuilder Class #32485

Added "/dd4hep::cm" to the DTGeometryBuilder Class #32485

slomeo commented Dec 14, 2020

cmsbuild commented Dec 14, 2020

cmsbuild commented Dec 14, 2020

cvuosalo commented Dec 14, 2020

cvuosalo Dec 14, 2020

cvuosalo Dec 14, 2020

slomeo Dec 15, 2020

cmsbuild commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

civanch commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

cvuosalo commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

qliphy commented Dec 16, 2020

Added "/dd4hep::cm" to the DTGeometryBuilder Class #32485

Added "/dd4hep::cm" to the DTGeometryBuilder Class #32485

Conversation

slomeo commented Dec 14, 2020

cmsbuild commented Dec 14, 2020

cmsbuild commented Dec 14, 2020

cvuosalo commented Dec 14, 2020

cvuosalo Dec 14, 2020

Choose a reason for hiding this comment

cvuosalo Dec 14, 2020

Choose a reason for hiding this comment

slomeo Dec 15, 2020

Choose a reason for hiding this comment

cmsbuild commented Dec 15, 2020

Comparison Summary

cmsbuild commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

civanch commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

Comparison Summary

cvuosalo commented Dec 15, 2020

cmsbuild commented Dec 15, 2020

qliphy commented Dec 16, 2020