New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Convert production cuts units using DD4hep-invariant method #32489
Conversation
@cmsbuild please test |
@smuzaffar @mrodozov The tests for this PR appear to be stuck. Could you please take a look? |
the code-checks failed due to disk issues on cmsdev23. I have restarted the code-checks job. Once that is finished successfully then PR tests will start. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32489/20423
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: SimG4Core/DD4hepGeometry @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34dec1/11718/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Production cuts are converted to mm for use in Geant4. This PR changes the method of conversion to the DD4hep method so it will work even when the DD4hep units convention changes.
PR validation:
Debug output from
SimG4Core/DD4hepGeometry/test/python/testG4Regions.py
from before and after the PR changes show that the production cuts are unchanged.A decision on whether to backport to 11_2 will be made later.