Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] Convert production cuts units using DD4hep-invariant method #32489

Merged
merged 2 commits into from Dec 16, 2020

Conversation

cvuosalo
Copy link
Contributor

Production cuts are converted to mm for use in Geant4. This PR changes the method of conversion to the DD4hep method so it will work even when the DD4hep units convention changes.

PR validation:

Debug output from SimG4Core/DD4hepGeometry/test/python/testG4Regions.py from before and after the PR changes show that the production cuts are unchanged.

A decision on whether to backport to 11_2 will be made later.

@cvuosalo
Copy link
Contributor Author

@cmsbuild please test

@cvuosalo
Copy link
Contributor Author

@smuzaffar @mrodozov The tests for this PR appear to be stuck. Could you please take a look?

@smuzaffar
Copy link
Contributor

the code-checks failed due to disk issues on cmsdev23. I have restarted the code-checks job. Once that is finished successfully then PR tests will start.
[a]
fatal: sha1 file '.git/objects/pack/tmp_pack_BwE8ad' write error: No space left on device

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32489/20423

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

SimG4Core/DD4hepGeometry
SimG4Core/Geometry

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34dec1/11718/summary.html
CMSSW: CMSSW_11_3_X_2020-12-15-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747284
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2747261
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@civanch
Copy link
Contributor

civanch commented Dec 16, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 16, 2020

+1

@cmsbuild cmsbuild merged commit b0c5576 into cms-sw:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants