Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T Phase2 NNTau reconstruction based on PF and Puppi (11_1_X backport) #32493

Merged
merged 20 commits into from Dec 19, 2020

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Dec 15, 2020

PR description:

11_1_X: L1T Phase2 NNTau reconstruction based on PF and Puppi

  • producers (PF and Puppi) and configurations
  • included in L1T Phase2 sequence
  • included in FEVTDEBUG Phase2 EventContent

all review comments from #31601 applied ( #32506 ).

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport to #31601 + #32506

@rekovic
Copy link
Contributor Author

rekovic commented Dec 15, 2020

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/Phase2L1ParticleFlow

@rekovic, @kpedro88, @jmduarte can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Dec 15, 2020

please test abort

@rekovic
Copy link
Contributor Author

rekovic commented Dec 15, 2020

don't see that the tests are started. so will abort and restart the testing

@rekovic
Copy link
Contributor Author

rekovic commented Dec 15, 2020

please abort test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80c1dc/11693/summary.html
CMSSW: CMSSW_11_1_X_2020-12-13-0000/slc7_amd64_gcc820

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Dec 16, 2020

please test

@cmsbuild
Copy link
Contributor

Pull request #32493 was updated. @rekovic, @kpedro88, @jmduarte can you please check and sign again.

@silviodonato
Copy link
Contributor

silviodonato commented Dec 16, 2020

@rekovic please update the PR description specifying that this is a backport of #31601 + #32506 .
PR #31600 is close

@silviodonato
Copy link
Contributor

urgent
for the HLT TDR release (11_1_X)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80c1dc/11742/summary.html
CMSSW: CMSSW_11_1_X_2020-12-13-0000/slc7_amd64_gcc820

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Dec 16, 2020

+1

@silviodonato silviodonato changed the title Pr 111 x l1 t phase2 nn tau L1T Phase2 NNTau reconstruction based on PF and Puppi (11_1_X backport) Dec 17, 2020
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 19, 2020

+1

@cmsbuild cmsbuild merged commit 87c8557 into cms-sw:CMSSW_11_1_X Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants