New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1T Phase2 NNTau reconstruction based on PF and Puppi (11_1_X backport) #32493
L1T Phase2 NNTau reconstruction based on PF and Puppi (11_1_X backport) #32493
Conversation
…ase, move member vars to private, Magic number 2.5 and 10, use PtEtaPhiMLorentzVector, use reco::deltaR2 reco::deltaPhi.,
please test |
A new Pull Request was created by @rekovic for CMSSW_11_1_X. It involves the following packages: L1Trigger/Configuration @rekovic, @kpedro88, @jmduarte can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test abort |
don't see that the tests are started. so will abort and restart the testing |
please abort test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80c1dc/11693/summary.html Comparison SummarySummary:
|
please test |
urgent |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80c1dc/11742/summary.html Comparison SummarySummary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
11_1_X: L1T Phase2 NNTau reconstruction based on PF and Puppi
all review comments from #31601 applied ( #32506 ).
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport to #31601 + #32506