Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New macros in Validation/RecoVertex (backport from 71x) #3251

Merged

Conversation

venturia
Copy link
Contributor

@venturia venturia commented Apr 8, 2014

All these changes are to add tools which exists already in 71x to help the Technical Proposal studies

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2014

A new Pull Request was created by @venturia for CMSSW_6_2_X_SLHC.

New macros in Validation/RecoVertex (backport from 71x)

It involves the following packages:

DPGAnalysis/SiStripTools
Validation/RecoVertex

@nclopezo, @danduggan, @rovere, @monttj, @cmsbuild, @deguio, @vadler, @ojeda, @Degano can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Tests 12200, 12400, 12600, 13800, 14000, 14200 and 14400 fail in step 2 with known errors.

@vadler
Copy link

vadler commented Apr 9, 2014

+1
if tests are fine. runTheMatrix seems to be broken in CMSSW_6_2_X_SLHC_2014-04-09-0200.

@mark-grimes
Copy link

@vadler Are you using "-w upgrade"? That is required for the SLHC tests, e.g.

runTheMatrix.py -j 6 -w upgrade -l 10000,10200,10400,11200,11400,12000,12800,13000,13600,14600

nclopezo added a commit that referenced this pull request Apr 9, 2014
New macros in Validation/RecoVertex (backport from 71x)
@nclopezo nclopezo merged commit fba68ac into cms-sw:CMSSW_6_2_X_SLHC Apr 9, 2014
@venturia venturia deleted the validation_recovertex-62x-slhc branch April 9, 2014 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants