Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLT subtables after the migration to EOS (11.1.x) #32516

Merged
merged 1 commit into from Dec 18, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 17, 2020

PR description:

Update the ConfDB subtables creation script following the migration of the repository from AFS to EOS:

  • fix a bug that prevented using the JAR files in-place;
  • update the curl command to follow redirects when downloading the JAR files over the web.

PR validation:

Creation of ConfDB subtables works again.

If this PR is a backport please specify the original PR and why you need to backport that PR:

Backport #32514

Update the ConfDB subtables creation script following the migration of the
repository from AFS to EOS:
  - fix a bug that prevented using the JAR files in-place;
  - update the curl command to follow redirects when downloading the JAR files
    over the web.
@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 17, 2020

backport #32514

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 17, 2020

type bug-fix

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 17, 2020

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1e2a3/11762/summary.html
CMSSW: CMSSW_11_1_X_2020-12-16-2300/slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1e2a3/11762/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1e2a3/11762/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784775
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 18, 2020

+1

@cmsbuild cmsbuild merged commit c2039b8 into cms-sw:CMSSW_11_1_X Dec 18, 2020
@fwyzard fwyzard deleted the update_subtables_111x branch December 21, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants