Modernize TriggerNames

[Dr15Jones]

PR description:

• Use more memory efficient data structure
• Avoid storing duplicate information to ROOT files
• Avoid a problem with std::vector::size_type on some compilers by just using std::size_t
• Added unit test

PR validation:

Code compiles and new unit tests pass.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32528/20480

• This PR adds an extra 16KB to repository

[Dr15Jones]

please test

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Common

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

(for future reference)

• Avoid a problem with std::vector::size_type on some compilers by just using std::size_t

Works around #32497.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7cc315/11774/summary.html
CMSSW: CMSSW_11_3_X_2020-12-17-1100/slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Introduce extend flag in HGCal validation #32508 @ebrondol: Introduce extend flag in HGCal validation
• Improve DD4hep workflow perf, step 1: All paths from SpecPar blocks with same name are stacked together #32505 @ghugo83: Improve DD4hep workflow perf, step 1: All paths from SpecPar blocks with same name are stacked together
• DeepCore (NN jetCore seeding) implementation  #32222 @vberta: DeepCore (NN jetCore seeding) implementation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7cc315/11774/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7cc315/11774/git-merge-result

DAS Queries failed

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 1991
• DQMHistoTests: Total nulls: 10838
• DQMHistoTests: Total successes: 2704116
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -31163.906 KiB( 35 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -1170.781 KiB Tracking/Track
• DQMHistoSizes: changed ( 10024.0,... ): -421.006 KiB Tracking/TrackTPPtLess09
• DQMHistoSizes: changed ( 10024.0,... ): -98.438 KiB Tracking/TrackBuilding
• DQMHistoSizes: changed ( 10024.0,... ): -28.125 KiB Tracking/TrackFromPV
• DQMHistoSizes: changed ( 10024.0,... ): -28.125 KiB Tracking/TrackConversion
• DQMHistoSizes: changed ( 10024.0,... ): -23.438 KiB Tracking/TrackFromPVAllTP
• DQMHistoSizes: changed ( 10024.0,... ): -14.062 KiB Tracking/TrackAllTPEffic
• DQMHistoSizes: changed ( 10024.0,... ): -7.031 KiB Tracking/TrackGsf
• DQMHistoSizes: changed ( 11624.911,... ): -49.219 KiB HLT/Tracking
• DQMHistoSizes: changed ( 11624.911,... ): -28.125 KiB HLT/Muon
• DQMHistoSizes: changed ( 11624.911 ): ...
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[makortel]

I'm fine with the changes, but would like to see cleaner comparisons with the next IB (and hence not restarting the tests yet).

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7cc315/11794/summary.html
CMSSW: CMSSW_11_3_X_2020-12-18-1100/slc7_amd64_gcc900

DAS Queries failed

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2716932
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[makortel]

+1

Reported differences are in messages

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1