Clean-up of L1 Tracker cluster, stub & track truth-reco association code

[tomalin]

PR description:

This is a clean-up of the code in SimTracker/TrackTriggerAssociation/ , which should not change the performance at all. The changes are:

1. Comments added to the reco-truth association classes of the CMS Upgrade L1 clusters, L1 stubs & L1 tracks in SimTracker/TrackTriggerAssociation/interface/*.h , to explain what they do, and the exact association criteria they use.
2. Several typedefs defined (some in SimTracker/TrackAssociation/ and others in DataFormats/ or SimDataFormats/ to replace the very long object type names (some exceeding 100 characters) appearing in SimTracker/TrackAssociation/
3. A very superficial cleanup of the producers in SimTracker/TrackAssociation/plugins/ , simply replacing a few "for loops" by their C++11 versions.

I've rerun the cluster & stub production & association on a GEN-SIM-RAW-MC (ttbar + 200PU), and checked that the L1 tracking performance is unchanged.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32549/20507

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32549/20507/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32549/20507/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32549/20510

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @tomalin (Ian Tomalin) for master.

It involves the following packages:

DataFormats/L1TrackTrigger
SimDataFormats/TrackingAnalysis
SimTracker/TrackTriggerAssociation

@civanch, @kpedro88, @jmduarte, @cmsbuild, @rekovic, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @Fedespring, @apsallid, @makortel, @trocino, @sviret, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @calderona, @HuguesBrun, @jhgoh, @lecriste, @threus, @ebrondol, @mtosi, @dgulhan, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

@tomalin can you give this PR a more meaningful/descriptive title?

[silviodonato]

please test

[tomalin]

I've implemented the code changes suggested by the review. (All nice ideas, thanks!).
I've not yet had time to revalidate the code following these changes, so the merge should wait until I have done so.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32549/20578

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #32549 was updated. @civanch, @kpedro88, @jmduarte, @cmsbuild, @rekovic, @mdhildreth can you please check and sign again.

[tomalin]

I've validated the revised code. The tracking performance and the output EDProducts are unchanged.

[kpedro88]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd00ef/11869/summary.html
CMSSW: CMSSW_11_3_X_2020-12-24-1100/slc7_amd64_gcc900

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dd00ef/1325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dd00ef/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716944
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[kpedro88]

+upgrade

[civanch]

+1

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1