Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME0 Flexible Description #3255

Merged
merged 3 commits into from Apr 9, 2014
Merged

ME0 Flexible Description #3255

merged 3 commits into from Apr 9, 2014

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Apr 8, 2014

  • Allow ME0 description depend on eta slope defined elsewhere

This will give different Eta coverage in different scenarios.

@ianna
Copy link
Contributor Author

ianna commented Apr 8, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

12200 (Extended2023HGCalMuon), 12600 (Extended2023SHCal4Eta) and 14400 (Extended2023HGCalMuon4Eta) now fail in step 1:

expr: mf___rMinME0 + 50*mm
------^
Evaluator : unknown variable
----- Begin Fatal Exception 09-Apr-2014 08:25:02 CEST-----------------------
An exception of category 'DDException' occurred while
   [0] Processing run: 1
   [1] Running path 'simulation_step'
   [2] Calling beginRun for module OscarProducer/'g4SimHits'
   [3] Using EventSetup component XMLIdealGeometryESSource/'' to make data DDCompactView/'' in record IdealGeometryRecord
Exception Message:
ClhepEvaluator ERROR: can't evaluate: [mf:rMinME0] + 50*mm!
 nmspace=mfshield
 varname=mf___rMinME0 + 50*mm
 exp=[mf:rMinME0] + 50*mm
  at=
----- End Fatal Exception -------------------------------------------------

@ianna
Copy link
Contributor Author

ianna commented Apr 9, 2014

@mark-grimes - Extended2023SHCal does not have ME0 included, but Extended2023SHCal4Eta does. Which one should I update? Does a scenario with Shashlik has to include ME0 or not?

@ianna
Copy link
Contributor Author

ianna commented Apr 9, 2014

@mark-grimes - I've included ME0 as documented on the twiki.

+1

@mark-grimes
Copy link

@ianna - I was going to say, all of my information comes from the twiki so I thought Extended2023SHCal has ME0 in. I'll test again now.

@mark-grimes
Copy link

merge

Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Tests 12200, 12400, 12600, 13800, 14000, 14200 and 14400 fail in step 2 with known errors.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

ME0 Flexible Description

It involves the following packages:

Geometry/CMSCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cmsbuild added a commit that referenced this pull request Apr 9, 2014
@cmsbuild cmsbuild merged commit f77b330 into cms-sw:CMSSW_6_2_X_SLHC Apr 9, 2014
@ianna ianna deleted the me0-3-eta branch October 26, 2015 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants