Run4-hgx272x Compress the property information of Wafers and tiles to reduce space requirement #32561

bsunanda · 2020-12-18T23:01:04Z

PR description:

Compress the property information of Wafers and tiles to reduce space requirement

PR validation:

Use runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

… requirement

cmsbuild · 2020-12-18T23:07:29Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32561/20521

This PR adds an extra 120KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32561/20521/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32561/20521/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-12-18T23:17:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32561/20522

This PR adds an extra 124KB to repository

cmsbuild · 2020-12-18T23:17:58Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2020-12-18T23:19:46Z

@cmsbuild Please test

cmsbuild · 2020-12-19T03:22:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed48be/11812/summary.html
CMSSW: CMSSW_11_3_X_2020-12-18-1100/slc7_amd64_gcc900

DAS Queries failed

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2716967
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2716938
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 153 log files, 37 edm output root files, 36 DQM output files

cvuosalo · 2020-12-21T21:47:01Z

+1

kpedro88 · 2020-12-23T19:56:22Z

Geometry/HGCalCommonData/interface/HGCalProperty.h

+#include <cmath>
+#include <cstdint>
+
+class HGCalProperty {


since all the functions are static and there are no member variables, this could just be a namespace instead of a class

kpedro88 · 2020-12-23T19:57:54Z

Geometry/HGCalCommonData/src/HGCalProperty.cc

@@ -0,0 +1,29 @@
+#include "Geometry/HGCalCommonData/interface/HGCalProperty.h"
+
+const int32_t kHGCalFactor = 10;


having these defined as globals in the global namespace is not preferred
better to put them inside the class/namespace

Using namespace

kpedro88 · 2020-12-23T19:58:37Z

Geometry/HGCalCommonData/test/HGCalConvert.cpp

@@ -51,6 +51,12 @@ const int kHGCalPhiOffset = 0;
 const int kHGCalPhiMask = 0x1FF;
 const int kHGCalRingOffset = 9;
 const int kHGCalRingMask = 0x1FF;
+const int kHGCalFactor = 10;


rather than duplicating the functionality of HGCalProperty, could that class/namespace be used directly in this test code?

cmsbuild · 2020-12-23T22:38:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32561/20569

This PR adds an extra 20KB to repository

cmsbuild · 2020-12-23T22:38:37Z

Pull request #32561 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

bsunanda · 2020-12-23T22:47:04Z

@cmsbuild Please test

cmsbuild · 2020-12-24T04:21:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed48be/11859/summary.html
CMSSW: CMSSW_11_3_X_2020-12-23-1100/slc7_amd64_gcc900

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ed48be/1325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ed48be/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2716967
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2716938
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

cvuosalo · 2020-12-24T16:49:26Z

+1

kpedro88 · 2020-12-24T17:02:02Z

+upgrade

cmsbuild · 2020-12-24T17:02:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-12-25T00:07:44Z

+1

Compress the property information of Wafers and tiles to reduce space…

92b32a5

… requirement

cmsbuild added this to the CMSSW_11_3_X milestone Dec 18, 2020

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Dec 18, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Dec 18, 2020

Code check

3bcb10c

cmsbuild added code-checks-pending and removed code-checks-rejected labels Dec 18, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 18, 2020

cmsbuild added tests-started and removed tests-pending labels Dec 18, 2020

cmsbuild added tests-approved and removed tests-started labels Dec 19, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Dec 21, 2020

kpedro88 reviewed Dec 23, 2020

View reviewed changes

Sunanda added 2 commits December 23, 2020 22:25

Take care of Kevin's comments

bf1a96d

Take care of Kevin's comments

3dd5257

cmsbuild added code-checks-rejected and removed code-checks-pending labels Dec 23, 2020

Code check

a845c48

cmsbuild added code-checks-pending tests-pending and removed code-checks-rejected tests-started labels Dec 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 23, 2020

cmsbuild added tests-started and removed tests-pending labels Dec 23, 2020

cmsbuild added tests-approved and removed tests-started labels Dec 24, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Dec 24, 2020

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Dec 24, 2020

cmsbuild added orp-approved and removed orp-pending labels Dec 25, 2020

cmsbuild merged commit 7346f16 into cms-sw:master Dec 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run4-hgx272x Compress the property information of Wafers and tiles to reduce space requirement #32561

Run4-hgx272x Compress the property information of Wafers and tiles to reduce space requirement #32561

bsunanda commented Dec 18, 2020

cmsbuild commented Dec 18, 2020

cmsbuild commented Dec 18, 2020

cmsbuild commented Dec 18, 2020

bsunanda commented Dec 18, 2020

cmsbuild commented Dec 19, 2020

cvuosalo commented Dec 21, 2020

kpedro88 Dec 23, 2020

bsunanda Dec 23, 2020

kpedro88 Dec 23, 2020

bsunanda Dec 23, 2020

kpedro88 Dec 23, 2020

bsunanda Dec 23, 2020

cmsbuild commented Dec 23, 2020

cmsbuild commented Dec 23, 2020

bsunanda commented Dec 23, 2020

cmsbuild commented Dec 24, 2020

cvuosalo commented Dec 24, 2020

kpedro88 commented Dec 24, 2020

cmsbuild commented Dec 24, 2020

qliphy commented Dec 25, 2020

		@@ -0,0 +1,29 @@
		#include "Geometry/HGCalCommonData/interface/HGCalProperty.h"

		const int32_t kHGCalFactor = 10;

Run4-hgx272x Compress the property information of Wafers and tiles to reduce space requirement #32561

Run4-hgx272x Compress the property information of Wafers and tiles to reduce space requirement #32561

Conversation

bsunanda commented Dec 18, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Dec 18, 2020

cmsbuild commented Dec 18, 2020

cmsbuild commented Dec 18, 2020

bsunanda commented Dec 18, 2020

cmsbuild commented Dec 19, 2020

Comparison Summary

cvuosalo commented Dec 21, 2020

kpedro88 Dec 23, 2020

Choose a reason for hiding this comment

bsunanda Dec 23, 2020

Choose a reason for hiding this comment

kpedro88 Dec 23, 2020

Choose a reason for hiding this comment

bsunanda Dec 23, 2020

Choose a reason for hiding this comment

kpedro88 Dec 23, 2020

Choose a reason for hiding this comment

bsunanda Dec 23, 2020

Choose a reason for hiding this comment

cmsbuild commented Dec 23, 2020

cmsbuild commented Dec 23, 2020

bsunanda commented Dec 23, 2020

cmsbuild commented Dec 24, 2020

Comparison Summary

cvuosalo commented Dec 24, 2020

kpedro88 commented Dec 24, 2020

cmsbuild commented Dec 24, 2020

qliphy commented Dec 25, 2020